disallow the blank values of Credential on the front.

astroshim · astroshim · commit e148d44e1085 · 2016-06-22T14:04:26.000+09:00
diff --git a/zeppelin-web/src/app/credential/credential.controller.js b/zeppelin-web/src/app/credential/credential.controller.js
@@ -21,15 +21,28 @@ angular.module('zeppelinWebApp').controller('CredentialCtrl', function($scope, $
   $scope.credentialEntity = '';
   $scope.credentialUsername = '';
   $scope.credentialPassword = '';
-  
+
   $scope.updateCredentials = function() {
+    if (_.isEmpty($scope.credentialEntity.trim()) ||
+        _.isEmpty($scope.credentialUsername.trim()) ||
+        _.isEmpty($scope.credentialPassword.trim())) {
+      BootstrapDialog.alert({
+        closable: true,
+        message: 'The values must be filled.'
+      });
+      return;
+    }
+
     $http.put(baseUrlSrv.getRestApiBase() + '/credential',
       { 'entity': $scope.credentialEntity,
         'username': $scope.credentialUsername,
         'password': $scope.credentialPassword
       } ).
     success(function (data, status, headers, config) {
-      alert('Successfully saved credentials');
+      BootstrapDialog.alert({
+        closable: true,
+        message: 'Successfully saved credentials.'
+      });
       $scope.credentialEntity = '';
       $scope.credentialUsername = '';
       $scope.credentialPassword = '';
