Skip to content

Commit dd857e5

Browse files
committed
Add separate setting menu
1 parent 4d1ce83 commit dd857e5

File tree

3 files changed

+38
-25
lines changed

3 files changed

+38
-25
lines changed

zeppelin-web/src/app/home/home.css

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -272,20 +272,29 @@ a.navbar-brand:hover {
272272
margin-top: 8px;
273273
}
274274

275-
.nav-config-btn {
275+
.nav-btn {
276276
color: #fff;
277277
background-color: #3071a9;
278278
border-color: #3071a9;
279279
}
280280

281-
.nav-config-btn:hover,
282-
.nav-config-btn:focus,
283-
.nav-config-btn:active, .open > .dropdown-toggle.nav-config-btn {
281+
.nav-btn:hover,
282+
.nav-btn:focus,
283+
.nav-btn:active, .open > .dropdown-toggle.nav-btn {
284284
color: #fff;
285285
background-color: #428bca;
286286
border-color: #357ebd;
287287
}
288288

289+
.nav-status-btn,
290+
.nav-status-btn:hover,
291+
.nav-status-btn:focus {
292+
color: #fff;
293+
background-color: #3071a9;
294+
border-color: #3071a9;
295+
cursor: default;
296+
}
297+
289298
.nav-login-btn,
290299
.nav-login-btn:hover,
291300
.nav-login-btn:focus {

zeppelin-web/src/components/navbar/navbar.controller.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ angular.module('zeppelinWebApp')
7676
$rootScope.truncatedUsername = $rootScope.ticket.principal;
7777
}
7878

79-
var MAX_USERNAME_LENGTH=20;
79+
var MAX_USERNAME_LENGTH=16;
8080

8181
angular.element('#notebook-list').perfectScrollbar({suppressScrollX: true});
8282

@@ -92,8 +92,7 @@ angular.module('zeppelinWebApp')
9292
if ($rootScope.ticket) {
9393
if ($rootScope.ticket.principal.length <= MAX_USERNAME_LENGTH) {
9494
$rootScope.truncatedUsername = $rootScope.ticket.principal;
95-
}
96-
else {
95+
} else {
9796
$rootScope.truncatedUsername = $rootScope.ticket.principal.substr(0, MAX_USERNAME_LENGTH) + '..';
9897
}
9998
}
@@ -146,7 +145,6 @@ angular.module('zeppelinWebApp')
146145
};
147146

148147
function getZeppelinVersion() {
149-
console.log('version');
150148
$http.get(baseUrlSrv.getRestApiBase() + '/version').success(
151149
function(data, status, headers, config) {
152150
$rootScope.zeppelinVersion = data.body;

zeppelin-web/src/components/navbar/navbar.html

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -82,29 +82,21 @@
8282
</form>
8383
<li class="nav-component">
8484
<div class="dropdown">
85-
<button class="btn nav-config-btn dropdown-toggle" type="button" data-toggle="dropdown" style="margin-right: 5px;">
85+
<button class="btn dropdown-toggle" type="button" data-toggle="dropdown" style="margin-right: 5px;"
86+
ng-class="{'nav-status-btn': !ticket.principal || ticket.principal === 'anonymous',
87+
'nav-btn': ticket.principal && ticket.principal !== 'anonymous'}">
8688
<i class="fa fa-circle" ng-class="{'server-connected':navbar.connected, 'server-disconnected':!navbar.connected}"></i>
8789
<span ng-show="navbar.connected" ng-if="ticket.principal === 'anonymous'">Connected</span>
8890
<span ng-show="navbar.connected" ng-if="ticket.principal !== 'anonymous'">{{truncatedUsername}}</span>
8991
<span ng-show="!navbar.connected">Disconnected</span>
90-
<span class="caret"></span>
92+
<span class="caret" ng-if="ticket.principal && ticket.principal !== 'anonymous'"></span>
9193
</button>
92-
<ul class="dropdown-menu">
93-
<li><a href="" data-toggle="modal" data-target="#aboutModal">
94-
<i class="fa fa-info"></i>&nbsp;&nbsp;About</a>
95-
</li>
96-
<li ng-if="ticket">
97-
<a href="#/interpreter">Interpreter</a>
98-
</li>
99-
<li ng-if="ticket">
100-
<a href="#/credential">Credential</a>
101-
</li>
102-
<li ng-if="ticket">
103-
<a href="#/configuration">Configuration</a>
104-
</li>
105-
<li ng-show="ticket.principal && ticket.principal!='anonymous'">
106-
<a ng-click="logout()">Logout</a>
94+
<ul class="dropdown-menu" ng-if="ticket.principal && ticket.principal !== 'anonymous'">
95+
<li class="dropdown-header">
96+
<strong>{{ticket.principal}}</strong>
10797
</li>
98+
<li role="separator" class="divider"></li>
99+
<li><a ng-click="logout()">Logout</a></li>
108100
</ul>
109101
</div>
110102
</li>
@@ -113,6 +105,20 @@
113105
ng-click="showLoginWindow()">Login
114106
</button>
115107
</li>
108+
<li class="nav-component" ng-if="ticket">
109+
<div class="dropdown">
110+
<button class="btn nav-btn dropdown-toggle" type="button" data-toggle="dropdown" style="margin-right: 5px;">
111+
<i class="fa fa-cog"></i>
112+
</button>
113+
<ul class="dropdown-menu">
114+
<li><a href="#/interpreter">Interpreter</a></li>
115+
<li><a href="#/credential">Credential</a></li>
116+
<li><a href="#/configuration">Configuration</a></li>
117+
<li role="separator" class="divider"></li>
118+
<li><a href="" data-toggle="modal" data-target="#aboutModal">About</a>
119+
</ul>
120+
</div>
121+
</li>
116122
</ul>
117123
</div>
118124
</div>

0 commit comments

Comments
 (0)