Skip to content

Commit cb673df

Browse files
hsuanxyzhsuanxyz
committed
chore: named TODOs
1 parent 826b6d4 commit cb673df

File tree

11 files changed

+27
-28
lines changed

11 files changed

+27
-28
lines changed

‎zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-data-type-map.interface.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export interface MessageSendDataTypeMap {
138138
[OP.ANGULAR_OBJECT_CLIENT_BIND]: AngularObjectClientBind;
139139
[OP.ANGULAR_OBJECT_CLIENT_UNBIND]: AngularObjectClientUnbind;
140140
[OP.CANCEL_PARAGRAPH]: CancelParagraph;
141-
[OP.PARAGRAPH_EXECUTED_BY_SPELL]: {}; // TODO
141+
[OP.PARAGRAPH_EXECUTED_BY_SPELL]: {}; // TODO(hsuanxyz)
142142
[OP.RUN_PARAGRAPH]: RunParagraph;
143143
[OP.RUN_ALL_PARAGRAPHS]: RunAllParagraphs;
144144
[OP.PARAGRAPH_REMOVE]: ParagraphRemove;
@@ -147,7 +147,7 @@ export interface MessageSendDataTypeMap {
147147
[OP.COMPLETION]: Completion;
148148
[OP.COMMIT_PARAGRAPH]: CommitParagraph;
149149
[OP.PATCH_PARAGRAPH]: PatchParagraphReceived;
150-
[OP.IMPORT_NOTE]: {}; // TODO
150+
[OP.IMPORT_NOTE]: {}; // TODO(hsuanxyz)
151151
[OP.CHECKPOINT_NOTE]: CheckpointNote;
152152
[OP.SET_NOTE_REVISION]: SetNoteRevision;
153153
[OP.LIST_REVISION_HISTORY]: ListRevisionHistory;

‎zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-paragraph.interface.ts‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export interface ParagraphEditorSetting {
4646
forms?: DynamicForms;
4747
}
4848

49-
// TODO
49+
// TODO(hsuanxyz)
5050
export interface ParagraphParams {
5151
// tslint:disable-next-line no-any
5252
[key: string]: any;
@@ -134,16 +134,15 @@ export interface ParagraphItem {
134134
dateStarted?: string;
135135
dateFinished?: string;
136136
errorMessage?: string;
137-
// tslint:disable-next-line no-any TODO
138137
runtimeInfos?: RuntimeInfos;
139138
status: string;
140139
title?: string;
141140
focus?: boolean;
142-
// tslint:disable-next-line no-any TODO
141+
// tslint:disable-next-line no-any TODO(hsuanxyz)
143142
aborted: any;
144-
// tslint:disable-next-line no-any TODO
143+
// tslint:disable-next-line no-any TODO(hsuanxyz)
145144
lineNumbers: any;
146-
// tslint:disable-next-line no-any TODO
145+
// tslint:disable-next-line no-any TODO(hsuanxyz)
147146
fontSize: any;
148147
}
149148

‎zeppelin-web-angular/src/app/app-runtime-compiler.providers.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const RUNTIME_COMPILER_PROVIDERS: StaticProvider[] = [
3535
{ provide: Compiler, useFactory: createCompiler, deps: [CompilerFactory] }
3636
];
3737

38-
// TODO
38+
// TODO(hsuanxyz)
3939
// buildOptimizer false
4040
// import 'core-js/es7/reflect';
4141
// https://github.com/angular/angular/issues/27584#issuecomment-446462051

‎zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export class NotebookActionBarComponent extends MessageListenersManager implemen
164164
}
165165

166166
setConfig() {
167-
// TODO
167+
// TODO(hsuanxyz)
168168
}
169169

170170
cloneNote() {
@@ -205,7 +205,7 @@ export class NotebookActionBarComponent extends MessageListenersManager implemen
205205
}
206206

207207
searchCode() {
208-
// TODO
208+
// TODO(hsuanxyz)
209209
}
210210

211211
deleteNote() {
@@ -229,7 +229,7 @@ export class NotebookActionBarComponent extends MessageListenersManager implemen
229229
}
230230

231231
showShortCut() {
232-
// TODO
232+
// TODO(hsuanxyz)
233233
}
234234

235235
togglePermissions() {

‎zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class NotebookComponent extends MessageListenersManager implements OnInit
114114
});
115115
this.note.paragraphs = [...this.note.paragraphs];
116116
this.cdr.markForCheck();
117-
// TODO focus on paragraph
117+
// TODO(hsuanxyz) focus on paragraph
118118
}
119119

120120
@MessageListener(OP.SAVE_NOTE_FORMS)
@@ -300,7 +300,7 @@ export class NotebookComponent extends MessageListenersManager implements OnInit
300300
this.revisionView = !!revisionId;
301301
this.cdr.markForCheck();
302302
this.messageService.listRevisionHistory(noteId);
303-
// TODO scroll to current paragraph
303+
// TODO(hsuanxyz) scroll to current paragraph
304304
});
305305
this.revisionView = !!this.activatedRoute.snapshot.params.revisionId;
306306
}

‎zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import { NotebookParagraphControlComponent } from '../control/control.component'
4040
changeDetection: ChangeDetectionStrategy.OnPush
4141
})
4242
export class NotebookParagraphCodeEditorComponent implements OnChanges, OnDestroy, AfterViewInit {
43-
// TODO:
43+
// TODO(hsuanxyz):
4444
// 1. cursor position
4545
@Input() readOnly = false;
4646
@Input() language = 'text';
@@ -164,7 +164,7 @@ export class NotebookParagraphCodeEditorComponent implements OnChanges, OnDestro
164164
if (match) {
165165
return match[1].trim();
166166
// get default interpreter name if paragraph text doesn't start with '%'
167-
// TODO(mina): dig into the cause what makes interpreterBindings to have no element
167+
// TODO(hsuanxyz): dig into the cause what makes interpreterBindings to have no element
168168
} else if (this.interpreterBindings && this.interpreterBindings.length !== 0) {
169169
return this.interpreterBindings[0].name;
170170
}
@@ -175,7 +175,7 @@ export class NotebookParagraphCodeEditorComponent implements OnChanges, OnDestro
175175
if (this.editor && !changed) {
176176
const model = this.editor.getModel();
177177
if (this.language) {
178-
// TODO: config convertMap
178+
// TODO(hsuanxyz): config convertMap
179179
const convertMap = {
180180
sh: 'shell'
181181
};

‎zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/control/control.component.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ export class NotebookParagraphControlComponent implements OnInit, OnChanges {
230230
}
231231

232232
goToSingleParagraph() {
233-
// TODO asIframe
233+
// TODO(hsuanxyz) asIframe
234234
const { noteId } = this.activatedRoute.snapshot.params;
235235
const redirectToUrl = `${location.protocol}//${location.host}${location.pathname}#/notebook/${noteId}/paragraph/${this.pid}`;
236236
window.open(redirectToUrl);
@@ -272,7 +272,7 @@ export class NotebookParagraphControlComponent implements OnInit, OnChanges {
272272
nzOnOk: () => {
273273
this.messageService.paragraphRemove(this.pid);
274274
this.cdr.markForCheck();
275-
// TODO moveFocusToNextParagraph
275+
// TODO(hsuanxyz) moveFocusToNextParagraph
276276
}
277277
});
278278
}

‎zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/footer/footer.component.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export class NotebookParagraphFooterComponent implements OnChanges {
6161
}
6262

6363
getElapsedTime() {
64-
// TODO dateStarted undefined after start
64+
// TODO(hsuanxyz) dateStarted undefined after start
6565
return `Started ${distanceInWordsToNow(this.dateStarted || new Date())} ago.`;
6666
}
6767

‎zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export class NotebookParagraphComponent extends MessageListenersManager implemen
208208
if (statusChanged || resultRefreshed) {
209209
// when last paragraph runs, zeppelin automatically appends new paragraph.
210210
// this broadcast will focus to the newly inserted paragraph
211-
// TODO
211+
// TODO(hsuanxyz)
212212
}
213213
this.cdr.markForCheck();
214214
}
@@ -268,14 +268,14 @@ export class NotebookParagraphComponent extends MessageListenersManager implemen
268268
this.messageService.runAllParagraphs(this.note.id, paragraphs);
269269
}
270270
});
271-
// TODO: save cursor
271+
// TODO(hsuanxyz): save cursor
272272
}
273273

274274
doubleClickParagraph() {
275275
if (this.paragraph.config.editorSetting.editOnDblClick && this.revisionView !== true) {
276276
this.paragraph.config.editorHide = false;
277277
this.paragraph.config.tableHide = true;
278-
// TODO: focus editor
278+
// TODO(hsuanxyz): focus editor
279279
}
280280
}
281281

@@ -299,7 +299,7 @@ export class NotebookParagraphComponent extends MessageListenersManager implemen
299299
this.messageService.runAllParagraphs(this.note.id, paragraphs);
300300
}
301301
});
302-
// TODO: save cursor
302+
// TODO(hsuanxyz): save cursor
303303
}
304304

305305
cloneParagraph(position: string = 'below') {
@@ -362,7 +362,7 @@ export class NotebookParagraphComponent extends MessageListenersManager implemen
362362
}
363363

364364
runParagraphUsingSpell(paragraphText: string, magic: string, propagated: boolean) {
365-
// TODO
365+
// TODO(hsuanxyz)
366366
}
367367

368368
runParagraphUsingBackendInterpreter(paragraphText: string) {
@@ -543,7 +543,7 @@ export class NotebookParagraphComponent extends MessageListenersManager implemen
543543
}
544544
// save dirtyText of moving paragraphs.
545545
const prevParagraph = this.note.paragraphs[newIndex];
546-
// TODO: save pre paragraph?
546+
// TODO(hsuanxyz): save pre paragraph?
547547
this.saveParagraph();
548548
this.triggerSaveParagraph.emit(prevParagraph.id);
549549
this.messageService.moveParagraph(this.paragraph.id, newIndex);
@@ -556,7 +556,7 @@ export class NotebookParagraphComponent extends MessageListenersManager implemen
556556
}
557557
// save dirtyText of moving paragraphs.
558558
const nextParagraph = this.note.paragraphs[newIndex];
559-
// TODO: save pre paragraph?
559+
// TODO(hsuanxyz): save pre paragraph?
560560
this.saveParagraph();
561561
this.triggerSaveParagraph.emit(nextParagraph.id);
562562
this.messageService.moveParagraph(this.paragraph.id, newIndex);

‎zeppelin-web-angular/src/app/services/note-status.service.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class NoteStatusService {
4141
}
4242

4343
isTrash(note: Note['note']) {
44-
// TODO https://github.com/apache/zeppelin/pull/3365/files
44+
// TODO(hsuanxyz) https://github.com/apache/zeppelin/pull/3365/files
4545
return note.name.split('/')[1] === this.TRASH_FOLDER_ID;
4646
}
4747

0 commit comments

Comments
 (0)