Show information to the user when there are errors with related to

Kavin · Kavin · commit 9f7cf678ea47 · 2016-09-25T22:30:50.000+05:30
permission on running paragraphs.
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -258,6 +258,12 @@ public void onMessage(NotebookSocket conn, String msg) {
       }
     } catch (Exception e) {
       LOG.error("Can't handle message", e);
+      try {
+        conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info",
+                "Oops! Something went wrong. Please check with your administrator.")));
+      } catch (IOException e1) {
+        LOG.error("Can't handle message", e);
+      }
     }
   }
 
diff --git a/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js b/zeppelin-web/src/components/websocketEvents/websocketEvents.factory.js
@@ -117,6 +117,21 @@ angular.module('zeppelinWebApp').factory('websocketEvents',
       $rootScope.$broadcast('noteRevision', data);
     } else if (op === 'INTERPRETER_BINDINGS') {
       $rootScope.$broadcast('interpreterBindings', data);
+    } else if (op === 'ERROR_INFO') {
+      BootstrapDialog.show({
+        closable: false,
+        closeByBackdrop: false,
+        closeByKeyboard: false,
+        title: 'Details',
+        message: data.info.toString(),
+        buttons: [{
+            // close all the dialogs when there are error on running all paragraphs
+            label: 'Close',
+            action: function() {
+              BootstrapDialog.closeAll();
+            }
+          }]
+      });
     }
   });
 
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java
@@ -139,7 +139,8 @@ public static enum OP {
     SAVE_INTERPRETER_BINDINGS,    // [c-s] save interpreter bindings
                                   // @param noteID
                                   // @param selectedSettingIds
-    INTERPRETER_BINDINGS          // [s-c] interpreter bindings
+    INTERPRETER_BINDINGS,         // [s-c] interpreter bindings
+    ERROR_INFO                    // [s-c] error information to be sent
   }
 
   public OP op;

Original file line number	Diff line number	Diff line change
`@@ -258,6 +258,12 @@ public void onMessage(NotebookSocket conn, String msg) {`
`258`	`258`	`}`
`259`	`259`	`} catch (Exception e) {`
`260`	`260`	`LOG.error("Can't handle message", e);`
	`261`	`+ try {`
	`262`	`+ conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info",`
	`263`	`+ "Oops! Something went wrong. Please check with your administrator.")));`
	`264`	`+ } catch (IOException e1) {`
	`265`	`+ LOG.error("Can't handle message", e);`
	`266`	`+ }`
`261`	`267`	`}`
`262`	`268`	`}`
`263`	`269`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,8 @@ public static enum OP {`
`139`	`139`	`SAVE_INTERPRETER_BINDINGS, // [c-s] save interpreter bindings`
`140`	`140`	`// @param noteID`
`141`	`141`	`// @param selectedSettingIds`
`142`		`- INTERPRETER_BINDINGS // [s-c] interpreter bindings`
	`142`	`+ INTERPRETER_BINDINGS, // [s-c] interpreter bindings`
	`143`	`+ ERROR_INFO // [s-c] error information to be sent`
`143`	`144`	`}`
`144`	`145`
`145`	`146`	`public OP op;`