Removed adduser while creating note

jongyoul · jongyoul · commit 6ed521a4ba78 · 2017-04-27T02:01:23.000+09:00
Added test to guarantee paragraph.getUserParagraph is different from paragraph itself
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
@@ -353,7 +353,6 @@ public Paragraph insertNewParagraph(int index, AuthenticationInfo authentication
   private Paragraph createParagraph(int index, AuthenticationInfo authenticationInfo) {
     Paragraph p = new Paragraph(this, this, factory, interpreterSettingManager);
     p.setAuthenticationInfo(authenticationInfo);
-    p.addUser(p, p.getUser());
     setParagraphMagic(p, index);
     return p;
   }
diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java
@@ -217,4 +217,20 @@ public void getNameWithoutNameItself() {
 
     assertEquals("getName should return same as getId when name is empty", note.getId(), note.getName());
   }
+
+  @Test
+  public void personalizedModeReturnDifferentParagraphInstancePerUser() {
+    Note note = new Note(repo, interpreterFactory, interpreterSettingManager, jobListenerFactory, index, credentials, noteEventListener);
+
+    String user1 = "user1";
+    String user2 = "user2";
+    note.setPersonalizedMode(true);
+    note.addNewParagraph(new AuthenticationInfo(user1));
+    Paragraph baseParagraph = note.getParagraphs().get(0);
+    Paragraph user1Paragraph = baseParagraph.getUserParagraph(user1);
+    Paragraph user2Paragraph = baseParagraph.getUserParagraph(user2);
+    assertNotEquals(System.identityHashCode(baseParagraph), System.identityHashCode(user1Paragraph));
+    assertNotEquals(System.identityHashCode(baseParagraph), System.identityHashCode(user2Paragraph));
+    assertNotEquals(System.identityHashCode(user1Paragraph), System.identityHashCode(user2Paragraph));
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,6 @@ public Paragraph insertNewParagraph(int index, AuthenticationInfo authentication`
`353`	`353`	`private Paragraph createParagraph(int index, AuthenticationInfo authenticationInfo) {`
`354`	`354`	`Paragraph p = new Paragraph(this, this, factory, interpreterSettingManager);`
`355`	`355`	`p.setAuthenticationInfo(authenticationInfo);`
`356`		`- p.addUser(p, p.getUser());`
`357`	`356`	`setParagraphMagic(p, index);`
`358`	`357`	`return p;`
`359`	`358`	`}`