Skip to content

Commit 4ef4e18

Browse files
astroshimAhyoungRyu
authored andcommitted
[ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_OUTPUT from the Interpreter.
### What is this PR for? This PR fixes the problem of streaming events(PARAGRAPH_APPEND_OUTPUT). It's because of the queue was not thread safe. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1991 ### How should this be tested? 1. make a spark paragraph 2. run following code on spark paragraph. ``` %spark (1 to 5).foreach{ i=> Thread.sleep(1000) println("Hello " + i) } ``` 3. make a python paragraph 4. run following code on python paragraph. ``` %python.python print("hi1") ``` 5. retry run step 2, and check if streaming working. ### Screenshots (if appropriate) - before ![2017-01-20 13_36_02](https://cloud.githubusercontent.com/assets/3348133/22166640/edb9f610-df16-11e6-926c-c781f618e6cf.gif) - after ![2017-01-20 13_52_53](https://cloud.githubusercontent.com/assets/3348133/22166840/efd855e4-df17-11e6-816c-17e069cd6a04.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1922 from astroshim/ZEPPELIN-1991 and squashes the following commits: e993585 [astroshim] make scheduler not static 66d3d2f [astroshim] fix to thread safe
1 parent 1a1fbc4 commit 4ef4e18

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterEventPoller.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
*/
5353
public class RemoteInterpreterEventPoller extends Thread {
5454
private static final Logger logger = LoggerFactory.getLogger(RemoteInterpreterEventPoller.class);
55-
private static final ScheduledExecutorService appendService =
55+
private final ScheduledExecutorService appendService =
5656
Executors.newSingleThreadScheduledExecutor();
5757
private final RemoteInterpreterProcessListener listener;
5858
private final ApplicationEventListener appListener;

0 commit comments

Comments
 (0)