Skip to content

Commit 294bea5

Browse files
hyonzinhyonzin
committed
Fix some wrong written term: Notebook -> Note
1 parent cc0d315 commit 294bea5

File tree

26 files changed

+184
-185
lines changed

26 files changed

+184
-185
lines changed

‎docs/rest-api/rest-notebook.md‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
142142
</tr>
143143
<tr>
144144
<td>URL</td>
145-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]```</td>
145+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]```</td>
146146
</tr>
147147
<tr>
148148
<td>Success code</td>
@@ -238,7 +238,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
238238
</tr>
239239
<tr>
240240
<td>URL</td>
241-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]```</td>
241+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]```</td>
242242
</tr>
243243
<tr>
244244
<td>Success code</td>
@@ -267,7 +267,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
267267
</tr>
268268
<tr>
269269
<td>URL</td>
270-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]```</td>
270+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]```</td>
271271
</tr>
272272
<tr>
273273
<td>Success code</td>
@@ -306,7 +306,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
306306
</tr>
307307
<tr>
308308
<td>URL</td>
309-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]```</td>
309+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]```</td>
310310
</tr>
311311
<tr>
312312
<td>Success code</td>
@@ -350,7 +350,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
350350
</tr>
351351
<tr>
352352
<td>URL</td>
353-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]```</td>
353+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]```</td>
354354
</tr>
355355
<tr>
356356
<td>Success code</td>
@@ -378,7 +378,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
378378
</tr>
379379
<tr>
380380
<td>URL</td>
381-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]```</td>
381+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]```</td>
382382
</tr>
383383
<tr>
384384
<td>Success code</td>
@@ -424,7 +424,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
424424
</tr>
425425
<tr>
426426
<td>URL</td>
427-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]```</td>
427+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]/[paragraphId]```</td>
428428
</tr>
429429
<tr>
430430
<td>Success code</td>
@@ -460,7 +460,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
460460
</tr>
461461
<tr>
462462
<td>URL</td>
463-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]```</td>
463+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]/[paragraphId]```</td>
464464
</tr>
465465
<tr>
466466
<td>Success code</td>
@@ -498,7 +498,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
498498
</tr>
499499
<tr>
500500
<td>URL</td>
501-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]```</td>
501+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]/[paragraphId]```</td>
502502
</tr>
503503
<tr>
504504
<td>Success code</td>
@@ -548,7 +548,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
548548
</tr>
549549
<tr>
550550
<td>URL</td>
551-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]```</td>
551+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[noteId]/[paragraphId]```</td>
552552
</tr>
553553
<tr>
554554
<td>Success code</td>
@@ -575,7 +575,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
575575
</tr>
576576
<tr>
577577
<td>URL</td>
578-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/cron/[notebookId]```</td>
578+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/cron/[noteId]```</td>
579579
</tr>
580580
<tr>
581581
<td>Success code</td>
@@ -607,7 +607,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
607607
</tr>
608608
<tr>
609609
<td>URL</td>
610-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/cron/[notebookId]```</td>
610+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/cron/[noteId]```</td>
611611
</tr>
612612
<tr>
613613
<td>Success code</td>
@@ -636,7 +636,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
636636
</tr>
637637
<tr>
638638
<td>URL</td>
639-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/cron/[notebookId]```</td>
639+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/cron/[noteId]```</td>
640640
</tr>
641641
<tr>
642642
<td>Success code</td>
@@ -702,7 +702,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
702702
</tr>
703703
<tr>
704704
<td>URL</td>
705-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]/paragraph```</td>
705+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]/paragraph```</td>
706706
</tr>
707707
<tr>
708708
<td>Success code</td>
@@ -752,7 +752,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
752752
</tr>
753753
<tr>
754754
<td>URL</td>
755-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]/paragraph/[paragraphId]```</td>
755+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]/paragraph/[paragraphId]```</td>
756756
</tr>
757757
<tr>
758758
<td>Success code</td>
@@ -819,7 +819,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
819819
</tr>
820820
<tr>
821821
<td>URL</td>
822-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]/paragraph/[paragraphId]/move/[newIndex]```</td>
822+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]/paragraph/[paragraphId]/move/[newIndex]```</td>
823823
</tr>
824824
<tr>
825825
<td>Success code</td>
@@ -847,7 +847,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
847847
</tr>
848848
<tr>
849849
<td>URL</td>
850-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[notebookId]/paragraph/[paragraphId]```</td>
850+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/[noteId]/paragraph/[paragraphId]```</td>
851851
</tr>
852852
<tr>
853853
<td>Success code</td>
@@ -874,7 +874,7 @@ If you work with Apache Zeppelin and find a need for an additional REST API, ple
874874
</tr>
875875
<tr>
876876
<td>URL</td>
877-
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/export/[notebookId]```</td>
877+
<td>```http://[zeppelin-server]:[zeppelin-port]/api/notebook/export/[noteId]```</td>
878878
</tr>
879879
<tr>
880880
<td>Success code</td>

‎zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
import org.apache.zeppelin.notebook.Paragraph;
5252
import org.apache.zeppelin.rest.message.CronRequest;
5353
import org.apache.zeppelin.types.InterpreterSettingsList;
54-
import org.apache.zeppelin.rest.message.NewNotebookRequest;
54+
import org.apache.zeppelin.rest.message.NewNoteRequest;
5555
import org.apache.zeppelin.rest.message.NewParagraphRequest;
5656
import org.apache.zeppelin.rest.message.RunParagraphWithParametersRequest;
5757
import org.apache.zeppelin.search.SearchService;
@@ -195,16 +195,16 @@ public Response bind(@PathParam("noteId") String noteId) {
195195
@GET
196196
@Path("/")
197197
@ZeppelinApi
198-
public Response getNotebookList() throws IOException {
198+
public Response getNoteList() throws IOException {
199199
AuthenticationInfo subject = new AuthenticationInfo(SecurityUtils.getPrincipal());
200-
List<Map<String, String>> notesInfo = notebookServer.generateNotebooksInfo(false, subject);
200+
List<Map<String, String>> notesInfo = notebookServer.generateNotesInfo(false, subject);
201201
return new JsonResponse<>(Status.OK, "", notesInfo).build();
202202
}
203203

204204
@GET
205205
@Path("{noteId}")
206206
@ZeppelinApi
207-
public Response getNotebook(@PathParam("noteId") String noteId) throws IOException {
207+
public Response getNote(@PathParam("noteId") String noteId) throws IOException {
208208
Note note = notebook.getNote(noteId);
209209
if (note == null) {
210210
return new JsonResponse<>(Status.NOT_FOUND, "note not found.").build();
@@ -223,7 +223,7 @@ public Response getNotebook(@PathParam("noteId") String noteId) throws IOExcepti
223223
@GET
224224
@Path("export/{id}")
225225
@ZeppelinApi
226-
public Response exportNoteBook(@PathParam("id") String noteId) throws IOException {
226+
public Response exportNote(@PathParam("id") String noteId) throws IOException {
227227
String exportJson = notebook.exportNote(noteId);
228228
return new JsonResponse<>(Status.OK, "", exportJson).build();
229229
}
@@ -256,7 +256,7 @@ public Response importNotebook(String req) throws IOException {
256256
@ZeppelinApi
257257
public Response createNote(String message) throws IOException {
258258
LOG.info("Create new notebook by JSON {}", message);
259-
NewNotebookRequest request = gson.fromJson(message, NewNotebookRequest.class);
259+
NewNoteRequest request = gson.fromJson(message, NewNoteRequest.class);
260260
AuthenticationInfo subject = new AuthenticationInfo(SecurityUtils.getPrincipal());
261261
Note note = notebook.createNote(subject);
262262
List<NewParagraphRequest> initialParagraphs = request.getParagraphs();
@@ -283,15 +283,15 @@ public Response createNote(String message) throws IOException {
283283
/**
284284
* Delete note REST API
285285
*
286-
* @param noteId ID of Notebook
286+
* @param noteId ID of Note
287287
* @return JSON with status.OK
288288
* @throws IOException
289289
*/
290290
@DELETE
291291
@Path("{noteId}")
292292
@ZeppelinApi
293293
public Response deleteNote(@PathParam("noteId") String noteId) throws IOException {
294-
LOG.info("Delete notebook {} ", noteId);
294+
LOG.info("Delete note {} ", noteId);
295295
AuthenticationInfo subject = new AuthenticationInfo(SecurityUtils.getPrincipal());
296296
if (!(noteId.isEmpty())) {
297297
Note note = notebook.getNote(noteId);
@@ -317,7 +317,7 @@ public Response deleteNote(@PathParam("noteId") String noteId) throws IOExceptio
317317
public Response cloneNote(@PathParam("noteId") String noteId, String message)
318318
throws IOException, CloneNotSupportedException, IllegalArgumentException {
319319
LOG.info("clone notebook by JSON {}", message);
320-
NewNotebookRequest request = gson.fromJson(message, NewNotebookRequest.class);
320+
NewNoteRequest request = gson.fromJson(message, NewNoteRequest.class);
321321
String newNoteName = null;
322322
if (request != null) {
323323
newNoteName = request.getName();

zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNotebookRequest.java renamed to zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNoteRequest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@
2323
import org.apache.zeppelin.interpreter.InterpreterOption;
2424

2525
/**
26-
* NewNotebookRequest rest api request message
26+
* NewNoteRequest rest api request message
2727
*
2828
*/
29-
public class NewNotebookRequest {
29+
public class NewNoteRequest {
3030
String name;
3131
List<NewParagraphRequest> paragraphs;
3232

33-
public NewNotebookRequest (){
33+
public NewNoteRequest (){
3434

3535
}
3636

‎zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -459,13 +459,13 @@ public void getInterpreterBindings(NotebookSocket conn, Message fromMessage)
459459
.put("interpreterBindings", settingList)));
460460
}
461461

462-
public List<Map<String, String>> generateNotebooksInfo(boolean needsReload,
463-
AuthenticationInfo subject) {
462+
public List<Map<String, String>> generateNotesInfo(boolean needsReload,
463+
AuthenticationInfo subject) {
464464

465465
Notebook notebook = notebook();
466466

467467
ZeppelinConfiguration conf = notebook.getConf();
468-
String homescreenNotebookId = conf.getString(ConfVars.ZEPPELIN_NOTEBOOK_HOMESCREEN);
468+
String homescreenNoteId = conf.getString(ConfVars.ZEPPELIN_NOTEBOOK_HOMESCREEN);
469469
boolean hideHomeScreenNotebookFromList = conf
470470
.getBoolean(ConfVars.ZEPPELIN_NOTEBOOK_HOMESCREEN_HIDE);
471471

@@ -481,7 +481,7 @@ public List<Map<String, String>> generateNotebooksInfo(boolean needsReload,
481481
for (Note note : notes) {
482482
Map<String, String> info = new HashMap<>();
483483

484-
if (hideHomeScreenNotebookFromList && note.getId().equals(homescreenNotebookId)) {
484+
if (hideHomeScreenNotebookFromList && note.getId().equals(homescreenNoteId)) {
485485
continue;
486486
}
487487

@@ -504,17 +504,17 @@ public void broadcastInterpreterBindings(String noteId,
504504
}
505505

506506
public void broadcastNoteList(AuthenticationInfo subject) {
507-
List<Map<String, String>> notesInfo = generateNotebooksInfo(false, subject);
507+
List<Map<String, String>> notesInfo = generateNotesInfo(false, subject);
508508
broadcastAll(new Message(OP.NOTES_INFO).put("notes", notesInfo));
509509
}
510510

511511
public void unicastNoteList(NotebookSocket conn, AuthenticationInfo subject) {
512-
List<Map<String, String>> notesInfo = generateNotebooksInfo(false, subject);
512+
List<Map<String, String>> notesInfo = generateNotesInfo(false, subject);
513513
unicast(new Message(OP.NOTES_INFO).put("notes", notesInfo), conn);
514514
}
515515

516516
public void broadcastReloadedNoteList(AuthenticationInfo subject) {
517-
List<Map<String, String>> notesInfo = generateNotebooksInfo(true, subject);
517+
List<Map<String, String>> notesInfo = generateNotesInfo(true, subject);
518518
broadcastAll(new Message(OP.NOTES_INFO).put("notes", notesInfo));
519519
}
520520

@@ -1342,7 +1342,7 @@ public void onNoteRemove(Note note) {
13421342

13431343
List<Map<String, Object>> notesInfo = new LinkedList<>();
13441344
Map<String, Object> info = new HashMap<>();
1345-
info.put("notebookId", note.getId());
1345+
info.put("noteId", note.getId());
13461346
// set paragraphs
13471347
List<Map<String, Object>> paragraphsInfo = new LinkedList<>();
13481348

@@ -1379,7 +1379,7 @@ public void onParagraphCreate(Paragraph p) {
13791379
@Override
13801380
public void onNoteCreate(Note note) {
13811381
Notebook notebook = notebookServer.notebook();
1382-
List<Map<String, Object>> notebookJobs = notebook.getJobListBymNotebookId(
1382+
List<Map<String, Object>> notebookJobs = notebook.getJobListByNoteId(
13831383
note.getId()
13841384
);
13851385
Map<String, Object> response = new HashMap<>();
@@ -1408,7 +1408,7 @@ public void onParagraphStatusChange(Paragraph p, Status status) {
14081408
@Override
14091409
public void onUnbindInterpreter(Note note, InterpreterSetting setting) {
14101410
Notebook notebook = notebookServer.notebook();
1411-
List<Map<String, Object>> notebookJobs = notebook.getJobListBymNotebookId(
1411+
List<Map<String, Object>> notebookJobs = notebook.getJobListByNoteId(
14121412
note.getId()
14131413
);
14141414
Map<String, Object> response = new HashMap<>();

‎zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,28 +147,28 @@ public void testGetNoteParagraphJobStatus() throws IOException {
147147
}
148148

149149
@Test
150-
public void testCloneNotebook() throws IOException {
150+
public void testCloneNote() throws IOException {
151151
Note note1 = ZeppelinServer.notebook.createNote(null);
152152
PostMethod post = httpPost("/notebook/" + note1.getId(), "");
153-
LOG.info("testCloneNotebook response\n" + post.getResponseBodyAsString());
153+
LOG.info("testCloneNote response\n" + post.getResponseBodyAsString());
154154
assertThat(post, isCreated());
155155
Map<String, Object> resp = gson.fromJson(post.getResponseBodyAsString(), new TypeToken<Map<String, Object>>() {
156156
}.getType());
157-
String clonedNotebookId = (String) resp.get("body");
157+
String clonedNoteId = (String) resp.get("body");
158158
post.releaseConnection();
159159

160-
GetMethod get = httpGet("/notebook/" + clonedNotebookId);
160+
GetMethod get = httpGet("/notebook/" + clonedNoteId);
161161
assertThat(get, isAllowed());
162162
Map<String, Object> resp2 = gson.fromJson(get.getResponseBodyAsString(), new TypeToken<Map<String, Object>>() {
163163
}.getType());
164164
Map<String, Object> resp2Body = (Map<String, Object>) resp2.get("body");
165165

166-
assertEquals((String)resp2Body.get("name"), "Note " + clonedNotebookId);
166+
assertEquals((String)resp2Body.get("name"), "Note " + clonedNoteId);
167167
get.releaseConnection();
168168

169169
//cleanup
170170
ZeppelinServer.notebook.removeNote(note1.getId(), null);
171-
ZeppelinServer.notebook.removeNote(clonedNotebookId, null);
171+
ZeppelinServer.notebook.removeNote(clonedNoteId, null);
172172

173173
}
174174
}

0 commit comments

Comments
 (0)