WICKET-7011 Swap assertion arguments to conform to expected vs actual #546
Conversation
|
Might have found an issue in When you change: diff --git a/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java b/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java
index 7eedb46fed..e1ac4b0883 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java
@@ -67,7 +67,7 @@ public class AppendingStringBufferTest
AppendingStringBuffer asb = new AppendingStringBuffer("123456789");
StringBuilder sb = new StringBuilder("123456789");
assertEquals(asb, sb);
- assertEquals(asb, "123456789");
+ assertEquals("123456789", asb);
sb = new StringBuilder("01234567890");
assertNotEquals(asb, sb);You get: Might be worth creating a separate issue for. |
Is it possible to do anything about it at our side ? |
|
Not sure if there's much we could do; the assertions end up calling: static boolean objectsAreEqual(Object obj1, Object obj2) {
if (obj1 == null) {
return (obj2 == null);
}
return obj1.equals(obj2);
}And I understand that For the test specifically we could maybe go with diff --git a/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java b/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java
index 7eedb46fed..e1ac4b0883 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/string/AppendingStringBufferTest.java
@@ -67,7 +67,7 @@ public class AppendingStringBufferTest
AppendingStringBuffer asb = new AppendingStringBuffer("123456789");
StringBuilder sb = new StringBuilder("123456789");
assertEquals(asb, sb);
- assertEquals(asb, "123456789");
+ assertEquals("123456789", asb.toString());
sb = new StringBuilder("01234567890");
assertNotEquals(asb, sb);That way you won't get the change suggested again in the future. |
|
I'm fine with this solution! |
|
Thanks for the quick review! I've kept the |
https://issues.apache.org/jira/browse/WICKET-7011
https://rules.sonarsource.com/java/RSPEC-3415
openrewrite/rewrite-testing-frameworks#275
openrewrite/rewrite-testing-frameworks#277