WICKET-6913 Replace CGLib with ByteBuddy #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Update the Objenesis related classes too and wicket-jmx (cherry picked from commit 8e1a15b)
(cherry picked from commit 43f040e)
Replace all occurrences of "cglib" with "byte-buddy". Merge AbstractByteBuddyInterceptor and ByteBuddyInterceptor. I see no need of both. If an application needs special impl of #writeReplace() then it could extend ByteBuddyInterceptor and override it. Improve Maven dependency management related to byte-buddy.
This is needed because otherwise we may get a cached generated class with wrong interceptor (i.e. IProxyTargetLocator) for classes with generics
svenmeier
approved these changes
Aug 15, 2021
martin-g
deleted the
WICKET-6913-replace-cglib-with-bytebuddy-wicket-10.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGLib is not well maintained and it does not work with JDK 17+.