[Unity] Avoid trivial var-to-var bindings in CanonicalizeBindings #15840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `relax.transform.CanonicalizeBindings` transform would detect trivial bindings `var_y = var_x`, and replace later usage of `var_y` with `var_x`. However, the trivial binding `var_y = var_x` would be left in the canonicalized function. This commit updates the `CanonicalizeBindings` transform to remove trivial bindings. This is not intended as a full dead-code elimination, as that is better handled as a separate pass, but is instead intended to avoid introduction of dead code during canonicalization.
Lunderberg
force-pushed
the
unity_avoid_unused_trivial_bindings_in_canonicalization
branch
from
3c2f562 to
0363f0b
Compare
Contributor
slyubomirsky
approved these changes
Oct 2, 2023
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
This all seems sound, thank you for the change!
Lunderberg
deleted the
unity_avoid_unused_trivial_bindings_in_canonicalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax.transform.CanonicalizeBindingstransform would detect trivial bindingsvar_y = var_x, and replace later usage ofvar_ywithvar_x. However, the trivial bindingvar_y = var_xwould be left in the canonicalized function.This commit updates the
CanonicalizeBindingstransform to remove trivial bindings. This is not intended as a full dead-code elimination, as that is better handled as a separate pass, but is instead intended to avoid introduction of dead code during canonicalization.