-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Unity] Add Relax multi-device e2e cases #15823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
100574c to
1dc6fbb
Compare
d4dc7f3 to
2c34952
Compare
zxybazh
reviewed
Sep 28, 2023
01703e1 to
69a0472
Compare
69a0472 to
5e86467
Compare
Member
zxybazh
approved these changes
Nov 2, 2023
Member
zxybazh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @yongwww!
5e86467 to
27fd9fd
Compare
c95d45f to
45eeb8c
Compare
27fd9fd to
9a93b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request enables Relax multi-device end-to-end test cases, including multi-CPU, multi-GPU, and heterogeneous CPU-GPU cases.
kTargetattribute toprim_funcduringLegalizeOpsif the related vdevice is annotated.ModulePass, find and fill the device_index in the emittedalloc_tensorby looking up the globalvdevicelist of context mod.targetargument ofrelax.buildoptional, and use the annotatedtargetin thevdevicelist for compilation if it is not specified.cc: @tqchen @psrivas2 @junrushao @csullivan @Lunderberg @zxybazh @qelk123