[Unity] Recursive pattern match in rewrite_call #15495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Lunderberg
force-pushed
the
pattern_match_rewrite_call_recursive
branch
from
a4125ec to
896d058
Compare
Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.
Lunderberg
force-pushed
the
pattern_match_rewrite_call_recursive
branch
from
896d058 to
4da8f3c
Compare
kparzysz-quic
approved these changes
Aug 10, 2023
Contributor
kparzysz-quic
left a comment
kparzysz-quic
left a comment
There was a problem hiding this comment.
We should probably add some guards against looping forever eventually in the fixed point rewriting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.
This commit updates
PatternMatcherto iterate until convergence when provided with a pattern, analogous to its current behavior when called throughrewrite_bindings.