-
Notifications
You must be signed in to change notification settings - Fork 351
Updated build ATS to 9.2.4 #7958
Conversation
|
Maybe this is a problem with building on OS X, but I run into an error following the test instructions |
Lemme try it with MacOS, with Linux (Ubuntu) it's working |
Don't quote me here, but I believe the issue with "realpath" being different in MacOS (BSD) than GNU realpath in Linux. That command is used in some bash scripts, for example, the pkg.sh script, not related with the PR itself. |
|
Was this build working prior to your change? |
It has to be something with the OS, with Linux I see there's no problem |
|
I'll retry on non Mac and see how it goes. I am usually able to build pkg
as part of my release verification
…On Mon, Mar 11, 2024 at 12:18 PM The Anh Nguyen ***@***.***> wrote:
Was this build working prior to your change?
It has to be something with the OS, with Linux I see there's no problem
—
Reply to this email directly, view it on GitHub
<#7958 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRNNBJP6EN3CATLPRID7TYXXKNHAVCNFSM6AAAAABEM62OSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYHAZTINZXG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Did you take a look? |
|
Can you review this PR after #7981 was merged? @zrhoffman |
zrhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zrhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides the tag pattern updates to update now that we have a proper release tag. Thanks!
|
@zrhoffman can you re-run the checks? I rebuild it and it works |
zrhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The CI is taking a long time for some reason, but I tested locally and it works.
As a note, the RPM still is built as 9.2.4-rc0, but that seems to be because ATS's version 9.2.4 was tagged incorrectly. So everything looks fine in #7958. :)
Actually, sometimes I see it will be like that, today I tried and the tag was 9.2.4 without rc0 |
Does this command print the git describe --match=9.2.4 9.2.4For me, it outputs . However, and work. |
for me, it outputs:
But after I removed the ats folder and rebuild ats |
When I run that command in a fresh clone of the ATS repo, I get |
|
I opened apache/trafficserver#11529, hopefully the release manager can investigate. |
Did you checkout to this commit?: |
|
run this command and gets the result: |
|
You're right, I get that result, and $ git describe --tags 9.2.3
9.2.3even though |
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist