Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@asf-ci-trafficcontrol
Copy link
Contributor

What does this PR (Pull Request) do?

This PR makes the Go components of Traffic Control build using Go version 1.21.7 and updates the golang.org/x/ dependencies.

See the Go 1.21.7 release notes:

go1.21.7 (released 2024-02-06) includes fixes to the compiler, the go command, the runtime, and the crypto/x509 package. See the Go 1.21.7 milestone on our issue tracker for details.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box - Enroller
  • CI tests for Go components
  • Build system - Go version in builder images

What is the best way to verify this PR?

Run unit tests and API tests. Since this is only a patch-level version update, the only changes were bugfixes. Breaking changes would be unexpected.

The following criteria are ALL met by this PR

  • Existing tests are sufficient, no additional tests necessary
  • The documentation only mentions the major Go version, no documentation updates necessary.
  • The changelog already mentions updating to Go 1.21, no additional changelog message necessary.
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (2190789) 31.75% compared to head (d82f1b1) 29.09%.
Report is 85 commits behind head on master.

Files Patch % Lines
cache-config/t3c-apply/config/config.go 0.00% 57 Missing ⚠️
cache-config/t3c-check-refs/t3c-check-refs.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7935      +/-   ##
============================================
- Coverage     31.75%   29.09%   -2.67%     
  Complexity       98       98              
============================================
  Files           717      605     -112     
  Lines         82786    77534    -5252     
  Branches        970       90     -880     
============================================
- Hits          26289    22558    -3731     
+ Misses        54339    52893    -1446     
+ Partials       2158     2083      -75     
Flag Coverage Δ
golib_unit 53.85% <ø> (+0.28%) ⬆️
grove_unit 12.02% <ø> (ø)
t3c_unit 5.88% <0.00%> (ø)
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 22.08% <ø> (+0.44%) ⬆️
traffic_portal_v2 ?
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 25.94% <0.00%> (-3.13%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman zrhoffman merged commit a12ad82 into master Feb 7, 2024
@zrhoffman zrhoffman deleted the go-1.21.7 branch February 7, 2024 15:15
rimashah25 pushed a commit to rimashah25/trafficcontrol that referenced this pull request Mar 20, 2024
zrhoffman added a commit that referenced this pull request Mar 20, 2024
* Update Chromedriver Versions (#7931)

* Update Go version to 1.21.7 (#7935)

* Update Chromedriver Versions (#7941)

Update chromedriver

(cherry picked from commit 8d1b4e3)

* Update Go version to 1.22.0 (#7940)

* Update Chromedriver Versions (#7942)

Update chromedriver

(cherry picked from commit 578f04e)

* Update Chromedriver Versions (#7949)

Update chromedriver

(cherry picked from commit f91c341)

* Update Chromedriver Versions (#7950)

Update chromedriver

(cherry picked from commit a423170)

* Bump ip from 1.1.8 to 1.1.9 in /experimental/traffic-portal/build (#7945)

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 6c6eebc)

* Bump es5-ext from 0.10.62 to 0.10.64 in /experimental/traffic-portal (#7951)

Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.62...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit e05e709)

* Update Chromedriver Versions (#7954)

Update chromedriver

(cherry picked from commit 1464dc2)

* Update Go version to 1.22.1 (#7955)

Co-authored-by: asf-ci-trafficcontrol <[email protected]>
(cherry picked from commit dc995a9)

* Fix incorrect display of delivery services for an ORG server (#7957)

* Update Chromedriver Versions (#7963)

Update chromedriver

(cherry picked from commit 26a2f6a)

* Changes for ATC 8.0.1 release.

* Remove cypress node dependency

* Updated changelog

* Updated node dependencies

* Removing minor change from PR 7957

* Removing minor change from PR 7553

---------

Co-authored-by: asf-ci-trafficcontrol <[email protected]>
Co-authored-by: Zach Hoffman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants