Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@shamrickus
Copy link
Member

This fixes #7674


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Ensure the migrations work both ways.
Verify that the documentation looks good and that the new fields are added to the servers servers/{{hostname}}/update_status and servers/{{hostname}}/update . The new fields should also be cdn lock permissible.

PR submission checklist

@shamrickus shamrickus added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #7750 (71189dd) into master (62bd082) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 26.66%.

@@             Coverage Diff              @@
##             master    #7750      +/-   ##
============================================
- Coverage     31.89%   31.87%   -0.03%     
  Complexity       98       98              
============================================
  Files           712      712              
  Lines         81875    81980     +105     
  Branches        965      965              
============================================
+ Hits          26111    26128      +17     
- Misses        53614    53702      +88     
  Partials       2150     2150              
Flag Coverage Δ
golib_unit 53.63% <0.00%> (-0.06%) ⬇️
grove_unit 12.02% <ø> (ø)
t3c_unit 5.99% <ø> (ø)
traffic_monitor_unit 26.33% <ø> (ø)
traffic_ops_integration 69.42% <81.81%> (+0.03%) ⬆️
traffic_ops_unit 21.59% <24.77%> (-0.03%) ⬇️
traffic_portal_v2 74.39% <ø> (+0.03%) ⬆️
traffic_stats_unit 10.76% <ø> (ø)
unit_tests 29.17% <21.77%> (-0.03%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <81.81%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/go-tc/servers.go 40.07% <0.00%> (-0.80%) ⬇️
...fic_ops/traffic_ops_golang/dbhelpers/db_helpers.go 20.49% <0.00%> (-0.22%) ⬇️
traffic_ops/traffic_ops_golang/server/update.go 0.00% <0.00%> (ø)
traffic_ops/traffic_ops_golang/server/servers.go 27.31% <33.33%> (+0.04%) ⬆️
...traffic_ops_golang/server/servers_update_status.go 62.33% <58.97%> (-1.21%) ⬇️
traffic_ops/v5-client/server_update_status.go 84.21% <77.77%> (+2.96%) ⬆️
traffic_ops/v5-client/server.go 67.32% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rimashah25 rimashah25 added this to the 8.0.0 milestone Aug 28, 2023
@shamrickus shamrickus added the documentation related to documentation label Aug 28, 2023
@shamrickus shamrickus force-pushed the to/cache-update-status branch from 119c1c2 to 0696ad5 Compare August 28, 2023 20:40
@shamrickus shamrickus requested a review from ocket8888 August 31, 2023 18:59
@ocket8888 ocket8888 merged commit 9d3c806 into apache:master Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation new feature A new feature, capability or behavior tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add update and reval flag to indicate failure

3 participants