This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix status code and alerts when querying delivery service with no SSL keys #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijeet0406
added
Traffic Ops
Codecov Report
@@ Coverage Diff @@
## master #7640 +/- ##
============================================
- Coverage 30.13% 30.12% -0.01%
Complexity 98 98
============================================
Files 794 794
Lines 84060 84077 +17
Branches 907 907
============================================
- Hits 25333 25332 -1
- Misses 56597 56615 +18
Partials 2130 2130
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericholguin
approved these changes
Jul 11, 2023
Contributor
ericholguin
left a comment
ericholguin
left a comment
There was a problem hiding this comment.
Looks good! Getting 200 for API v4 and 404 for API v5
zrhoffman
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4393.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Follow the steps in the related Github issue #4393.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist