This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix status code and alert structure for sslkeys endpoint, when no ssl keys are present. #7595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keys are present
Codecov Report
@@ Coverage Diff @@
## master #7595 +/- ##
=============================================
- Coverage 64.80% 30.29% -34.51%
Complexity 98 98
=============================================
Files 201 793 +592
Lines 8158 83442 +75284
Branches 898 898
=============================================
+ Hits 5287 25281 +19994
- Misses 2689 56040 +53351
- Partials 182 2121 +1939
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 592 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
added
bug
shamrickus
approved these changes
Jun 28, 2023
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- Fixes the issue in v5 only
- Returns the correct status code
- TP integration tests pass locally
Member
|
Reverted in 7d5cebe due to breaking |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4393.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Follow the steps in the related Github issue #4393.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist