Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fixes alert message for POST and PUT invalidationjobs API #7517

Merged
ocket8888 merged 3 commits into from
May 25, 2023
Merged

Fixes alert message for POST and PUT invalidationjobs API #7517

ocket8888 merged 3 commits into from
May 25, 2023

Conversation

@rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented May 12, 2023 •
edited
Loading

Closes: #6340

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Create an invalidation job (REFETCH) without refetch_enabled parameter and check the new message.
Create an invalidation job (REFRESH) without refetch_enabled parameter or refetch_enabled parameter value set to false and then using PUT API try and change the job from REFRESH to REFETCH.

If this is a bugfix, which Traffic Control versions contained the bug?

7.0.1

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review May 12, 2023 18:19
@rimashah25 rimashah25 requested a review from ocket8888 May 12, 2023 18:19
@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #7517 (4e6eeef) into master (1cad456) will decrease coverage by 34.85%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #7517       +/-   ##
=============================================
- Coverage     65.10%   30.26%   -34.85%     
  Complexity       98       98               
=============================================
  Files           309      789      +480     
  Lines         11934    82551    +70617     
  Branches        840      840               
=============================================
+ Hits           7770    24980    +17210     
- Misses         3816    55467    +51651     
- Partials        348     2104     +1756
Flag Coverage Δ
golib_unit 48.57% <ø> (?)
grove_unit 4.60% <ø> (?)
t3c_unit 5.32% <ø> (?)
traffic_monitor_unit 21.28% <ø> (?)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 23.37% <0.00%> (?)
traffic_portal_v2 74.74% <ø> (-0.03%) ⬇️
traffic_stats_unit 10.14% <ø> (?)
unit_tests 27.33% <0.00%> (-47.43%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ic_ops_golang/invalidationjobs/invalidationjobs.go 0.00% <0.00%> (ø)

... and 481 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 self-assigned this May 12, 2023
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. labels May 12, 2023
@rimashah25 rimashah25 force-pushed the bugfix/invalidation-alert branch 3 times, most recently from e17150b to 5199ac8 Compare May 18, 2023 20:35
ocket8888
ocket8888 suggested changes May 22, 2023
View reviewed changes
@rimashah25 rimashah25 force-pushed the bugfix/invalidation-alert branch from 5199ac8 to 4e6eeef Compare May 23, 2023 04:25
@rimashah25 rimashah25 requested a review from ocket8888 May 23, 2023 04:26
@ocket8888
Copy link
Contributor

ocket8888 commented May 23, 2023

I've restarted the t3c tests and they just failed again. They're passing consistently on master, so I'm not sure why but I think it's a real error?

ocket8888
ocket8888 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this fixes the error messages. I have no idea how changing an error message is causing Traffic Portal and T3C integration tests to fail, and I can't get them to work well enough to troubleshoot outside of actions, so I'm going to just ignore the problem and hope it goes away. If not, then hopefully it'll at least annoy someone who can fix it.

@ocket8888 ocket8888 merged commit 6ec05e5 into apache:master May 25, 2023
@rimashah25 rimashah25 deleted the bugfix/invalidation-alert branch June 1, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ocket8888 ocket8888 ocket8888 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocket8888 ocket8888

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalidation Type restricted message could be better

2 participants

@rimashah25 @ocket8888