This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixes service_categories response to POST API #7383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated GenericCreateNameBasedID in api/generic_crud.go and used it in Create() function traffic_ops_golang/servicecategory.go
…ories while not breaking other functionalities that existed earlier.
jagan-parthiban
changed the title
jagan-parthiban
changed the title
jagan-parthiban
changed the title
ocket8888
changed the title
rimashah25
reviewed
Mar 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #7383 +/- ##
============================================
- Coverage 26.12% 26.11% -0.01%
Complexity 98 98
============================================
Files 648 648
Lines 76280 76293 +13
Branches 90 90
============================================
Hits 19925 19925
- Misses 54520 54533 +13
Partials 1835 1835
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
approved these changes
Mar 10, 2023
Contributor
rimashah25
left a comment
rimashah25
left a comment
There was a problem hiding this comment.
LGTM. Tested it on local and see the actual name in alert response.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7130
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run a
/POSTcall to/api/4.0/service_categories"and confirm that success response includes name. As well ensure existing functionality (CRUDER, eg:/server_capabiilities) still works as intended.If this is a bugfix, which Traffic Control versions contained the bug?
7.0.1
PR submission checklist