This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix Internal Server Error when a Delivery Service's orgServerFqdn is an empty string, in some situations #7382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
bug
Codecov Report
@@ Coverage Diff @@
## master #7382 +/- ##
============================================
+ Coverage 26.12% 26.15% +0.03%
Complexity 98 98
============================================
Files 648 650 +2
Lines 76280 76287 +7
Branches 90 90
============================================
+ Hits 19925 19951 +26
+ Misses 54520 54500 -20
- Partials 1835 1836 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
reviewed
Mar 13, 2023
srijeet0406
approved these changes
Mar 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6775
Adds a check that string pointers which are "required" fields for a given DS type not be empty, whereas previously it only checked if they were nil.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the provided unit tests
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist