This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 351
Fix integer overflow for czCount #7272
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7272 +/- ##
=========================================
Coverage 28.29% 28.29%
Complexity 98 98
=========================================
Files 617 617
Lines 69650 69650
Branches 90 90
=========================================
Hits 19704 19704
Misses 48126 48126
Partials 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
approved these changes
Jan 9, 2023
Contributor
rimashah25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Haven't tested it (new test case) on local.
zrhoffman
suggested changes
Jan 9, 2023
...er/core/src/main/java/org/apache/traffic_control/traffic_router/core/router/StatTracker.java
Show resolved
Hide resolved
zrhoffman
suggested changes
Jan 9, 2023
...ore/src/test/java/org/apache/traffic_control/traffic_router/core/router/StatTrackerTest.java
Outdated
Show resolved
Hide resolved
zrhoffman
approved these changes
Jan 9, 2023
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #7252
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Follow the steps in the linked GH issue
Make sure all the tests pass
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist