This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix APIv4.0 returning APIv4.1 DS structures #7156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
bug
zrhoffman
suggested changes
Oct 25, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Almost ready to merge, just 1 comment
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
ocket8888
force-pushed
the
to/fix-ds-versioning
branch
from
1450645 to
6c53292
Compare
zrhoffman
suggested changes
Oct 25, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
API tests fail
--- FAIL: TestDeliveryServices (4.98s)
--- FAIL: TestDeliveryServices/GET (0.01s)
--- FAIL: TestDeliveryServices/GET/OK_when_VALID_XMLID_parameter (0.01s)
panic: interface conversion: interface {} is []tc.DeliveryServiceV41, not []tc.DeliveryServiceV40 [recovered]
panic: interface conversion: interface {} is []tc.DeliveryServiceV41, not []tc.DeliveryServiceV40
zrhoffman
reviewed
Oct 25, 2022
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by #7111 where APIv4.0 responses containing representations of Delivery Services used the representation from APIv4.1.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests still pass, request Delivery Services at APIv4.0 and observe no
regionalproperty, then again at APIv4.1 and observe that it now does have the v4.1regionalproperty.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist