Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Divide MaxOriginConnections over a Server's own Cache Group if DS Regional field is set #7127

Merged
rawlinp merged 3 commits into from
Oct 14, 2022
Merged

Divide MaxOriginConnections over a Server's own Cache Group if DS Regional field is set #7127

rawlinp merged 3 commits into from
Oct 14, 2022

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Oct 12, 2022

This PR resolves #7097 by having t3c divide MaxOriginConnections over a Server's own Cache Group if the Delivery Service's Regional field is set.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

  • Run the t3c integration tests
  • Run the lib/go-atscfg unit tests

PR submission checklist

@zrhoffman zrhoffman added new feature A new feature, capability or behavior cache-config Cache config generation labels Oct 12, 2022
@ocket8888 ocket8888 added the low impact affects only a small portion of a CDN, and cannot itself break one label Oct 12, 2022
jpappa200
jpappa200 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jpappa200 jpappa200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see a changelog entry, other than that looks good to me.

@rawlinp rawlinp merged commit 994119d into apache:master Oct 14, 2022
@zrhoffman zrhoffman deleted the regional-moc branch October 26, 2022 15:53
@zrhoffman zrhoffman added the medium impact impacts a significant portion of a CDN, or has the potential to do so label Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jpappa200 jpappa200 jpappa200 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cache-config Cache config generation low impact affects only a small portion of a CDN, and cannot itself break one medium impact impacts a significant portion of a CDN, or has the potential to do so new feature A new feature, capability or behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

For a Regional Delivery Service, MaxOriginConnections should only be divided among Servers within a single Cache Group

4 participants

@zrhoffman @jpappa200 @ocket8888 @rawlinp