This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group #7111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
added
new feature
ocket8888
reviewed
Oct 5, 2022
3 tasks
Member
Author
|
Added the Regional field to Traffic Portal v1 in 9b4c1f3 |
ocket8888
reviewed
Oct 6, 2022
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
Outdated
Show resolved
Hide resolved
zrhoffman
force-pushed
the
regional-field
branch
from
979245e to
9b4c1f3
Compare
ocket8888
reviewed
Oct 6, 2022
maxOriginConnections is nonzero
Service with nonzero maxOriginConnections
ocket8888
reviewed
Oct 11, 2022
ocket8888
reviewed
Oct 11, 2022
| data.ipAddress = `${rand()}.${rand()}.${rand()}.${rand()}`; | ||
| } | ||
| if(hasProperty(data, 'name') && !hasProperty(data, 'noRandomize')) { | ||
| if(hasProperty(data, 'name') && !(hasProperty(data, "noRandomize") && data.noRandomize === true)) { |
Contributor
There was a problem hiding this comment.
nit: booleans shouldn't be compared to boolean constants, in general.
ocket8888
approved these changes
Oct 11, 2022
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the Traffic Ops and Traffic Portal portions of #7097 by adding the
Regionalflag to Delivery Services for API versions 4 and up.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
PR submission checklist