Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fixed server table's quick search and filter for multiple profiles #7074

Merged
ocket8888 merged 5 commits into from
Sep 30, 2022
Merged

Fixed server table's quick search and filter for multiple profiles #7074

ocket8888 merged 5 commits into from
Sep 30, 2022

Conversation

@rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Sep 19, 2022 •
edited
Loading

Fixes: #7049 and
Fixes: #7052

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Add servers with multiple profiles and quick search and filter for any profile that is not a primary profile

If this is a bugfix, which Traffic Control versions contained the bug?

7.0.1 (master)

PR submission checklist

  • This PR has no tests as it only changes the display of a table column (UI).
  • This PR has documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one labels Sep 19, 2022
@ocket8888 ocket8888 self-assigned this Sep 21, 2022
ocket8888
ocket8888 reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the search and appears to render fine, but some other tables aren't displaying Profiles for servers properly, e.g. the Delivery Service server-assignment table pictured below.

image

Also, #7049 specifically mentions viewing servers filtered by Profile via the "View Servers" menu option on a Profile's page. This PR doesn't fix that.

Also, the table column name is currently still 'Profile', should probably now be 'Profiles' or perhaps 'Profile(s)'. But that's less important.

@rimashah25 rimashah25 force-pushed the bugfix/search-multiple-profile branch from c1a5a31 to a44001f Compare September 26, 2022 18:43
@rimashah25
Copy link
Contributor Author

rimashah25 commented Sep 26, 2022

This fixes the search and appears to render fine, but some other tables aren't displaying Profiles for servers properly, e.g. the Delivery Service server-assignment table pictured below.

image

Also, #7049 specifically mentions viewing servers filtered by Profile via the "View Servers" menu option on a Profile's page. This PR doesn't fix that.

Also, the table column name is currently still 'Profile', should probably now be 'Profiles' or perhaps 'Profile(s)'. But that's less important.

Resolved #7049 (filtered by Profile using column Filter).

ocket8888
ocket8888 reviewed Sep 29, 2022
View reviewed changes
@rimashah25 rimashah25 force-pushed the bugfix/search-multiple-profile branch from 93ccc0b to df9bf72 Compare September 29, 2022 20:19
ocket8888
ocket8888 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@ocket8888 ocket8888 merged commit 4e352e8 into apache:master Sep 30, 2022
@asf-ci asf-ci mentioned this pull request Oct 1, 2022
Merged
4 tasks
@rimashah25 rimashah25 deleted the bugfix/search-multiple-profile branch February 8, 2023 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ocket8888 ocket8888 ocket8888 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocket8888 ocket8888

Labels

bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Traffic Portal v1 - Quick Search does not work for second/layered profiles Traffic Portal (v1) - Servers do not display for layered/multi profiles

2 participants

@rimashah25 @ocket8888