This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 351
Allow update time params on Servers when CDN is locked. #7065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cdeaa4 to
dd4bec0
Compare
srijeet0406
reviewed
Sep 13, 2022
srijeet0406
reviewed
Sep 15, 2022
srijeet0406
approved these changes
Sep 15, 2022
Contributor
srijeet0406
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual and automated tests pass.
Code looks good.
5 tasks
rob05c
pushed a commit
to rob05c/trafficcontrol
that referenced
this pull request
Sep 19, 2022
* Allow lock updates on some server params * Add CHANGELOG and dont update when non-allowed fields are present. * Sort changelog * Fix issues * Code review and add to v5 tests
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Allow lock updates on some server params * Add CHANGELOG and dont update when non-allowed fields are present. * Sort changelog * Fix issues * Code review and add to v5 tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
go
Pull requests that update Go or Go-related code
improvement
The functionality exists but it could be improved in some way.
Traffic Ops
related to Traffic Ops
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7047
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the tests and verify that they pass. Lock a CDN and then call the
servers/{id}/updateendpoint with either/bothconfig_apply_timeandrevalidate_apply_timeoptions successfully.PR submission checklist