Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@shamrickus
Copy link
Member

This PR fixes #7047


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run the tests and verify that they pass. Lock a CDN and then call the servers/{id}/update endpoint with either/both config_apply_time and revalidate_apply_time options successfully.

PR submission checklist

@shamrickus shamrickus added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. go Pull requests that update Go or Go-related code labels Sep 7, 2022
@shamrickus shamrickus force-pushed the to/lock-allow branch 2 times, most recently from 9cdeaa4 to dd4bec0 Compare September 8, 2022 16:31
Copy link
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual and automated tests pass.
Code looks good.

@srijeet0406 srijeet0406 merged commit 4631c3a into apache:master Sep 15, 2022
@shamrickus shamrickus deleted the to/lock-allow branch September 15, 2022 19:12
rob05c pushed a commit to rob05c/trafficcontrol that referenced this pull request Sep 19, 2022
* Allow lock updates on some server params

* Add CHANGELOG and dont update when non-allowed fields are present.

* Sort changelog

* Fix issues

* Code review and add to v5 tests
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 2, 2022
* Allow lock updates on some server params

* Add CHANGELOG and dont update when non-allowed fields are present.

* Sort changelog

* Fix issues

* Code review and add to v5 tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

go Pull requests that update Go or Go-related code improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TO /api/4.0/servers/:hostname/update should allow setting config_apply_time and revalidate_apply_time even if user doesn't have the lock

2 participants