This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Convert Traffic Ops into a Service Oriented architecture(SOA) product #6754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
added
new feature
srijeet0406
removed
the
needs more info
ocket8888
reviewed
Apr 18, 2022
rawlinp
suggested changes
Apr 23, 2022
rawlinp
suggested changes
Apr 28, 2022
ocket8888
reviewed
May 2, 2022
Contributor
There was a problem hiding this comment.
I didn't mean to look at anything but the docs, but then I looked at the configuration that it was including, then the related production configuration file that was based on it and wound up glancing at most everything. I'm not looking too hard at any of the logic though - I'm not trying to make a hostile takeover of the review.
rawlinp
approved these changes
May 10, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
…apache#6754) * initial changes * working changes * formatting and cleanup * cleanup * adding log handlers * add dcos, cleanup * add todos * add todos * cleanup config * add insecure option to backend config * Adding proper log handlers * remove priv level from backend config * code review first pass * code review fixes final * change log call * change mutex type * addressing code review comments * change regex handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue.
It adds the ability in Traffic Ops, so that it can be run in conjunction with other backend services, wherein TO would just act as a reverse proxy and forward the requests coming in on the specified paths to the specified backends.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Set up a simple backend service that servers a couple of endpoints (say
fooandfoos) and run it on a couple of different ports(say, 8444 and 8445). Now, run Traffic Ops with the new config option and make sure that any request to Traffic Ops on the specified endpoints (in the new config) gets forwarded to the backend service. Also make sure that the user sees the response from the backend service.The new config option should be provided to traffic ops like this:
-backendcfg <File name>The new config file should look something like this:
{ "routes": [ { "path": "^/api/4.0/foo/?$", "method": "GET", "hosts": [ "localhost:8444" ], "insecure": true, "permissions": [ "CDN:READ" ], "routeId": 123456, "opts": { "alg": "roundrobin" } }, { "path": "^/api/4.0/foos/?$", "method": "GET", "hosts": [ "localhost:8444" ], "insecure": true, "permissions": [ "CDN:READ" ], "routeId": 123457, "opts": { "alg": "roundrobin" } } ] }Make sure all the tests pass.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist