Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Mar 18, 2022

This PR fixes #6343 by causing the t3c integration tests's Traffic Server RPM SPEC to exclude release candidate tags in the version number.
Before:

trafficserver-8.1.4_rc0-0.965df952e.el8.x86_64.rpm

After:

trafficserver-8.1.3-10-965df952e.el8.x86_64.rpm

This matches the behavior expected by the fetch-github-branch-sha GitHub Action and the ats-version.sh script used by the CDN in a Box makefile, so

  • this should make the CDN in a Box GHA workflow pass again
  • this should fix ATS RPM caching

Note that the t3c integration tests still fail, but that failure is not caused by this PR.


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT) - ATS RPM
  • CDN in a Box - ATS RPM

What is the best way to verify this PR?

Check the RPM name generated by the trafficserver step of the cache-config tests

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

Anything else

git describe --exclude='*[^0-9.]*'

would have been cleaner than

git describe --match='*[0-9.][0-9.][0-9.]'

but --exclude is not supported in git version 1.8.3.1, the version used in CentOS 7 currently.

@zrhoffman zrhoffman added Traffic Server related to Apache Traffic Server cdn-in-a-box related to the Docker-based CDN-in-a-Box system cache-config Cache config generation automation related to automated testing/deployment/packaging etc. labels Mar 18, 2022
@rawlinp rawlinp merged commit 0ee927a into apache:master Mar 18, 2022
@zrhoffman zrhoffman deleted the no-rc-tag branch March 18, 2022 22:00
@zrhoffman zrhoffman added the build related to the build process label Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. build related to the build process cache-config Cache config generation cdn-in-a-box related to the Docker-based CDN-in-a-Box system Traffic Server related to Apache Traffic Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: unknown option `exclude=*.*.*-rc*'

2 participants