This repository was archived by the owner on Nov 24, 2025. It is now read-only.
ATS RPM: Only match tags ending in 3 digits or dots #6678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6343 by causing the t3c integration tests's Traffic Server RPM SPEC to exclude release candidate tags in the version number.
Before:
After:
This matches the behavior expected by the fetch-github-branch-sha GitHub Action and the
ats-version.shscript used by the CDN in a Box makefile, soNote that the t3c integration tests still fail, but that failure is not caused by this PR.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT) - ATS RPMWhat is the best way to verify this PR?
Check the RPM name generated by the
trafficserverstep of the cache-config testsIf this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
Anything else
git describe --exclude='*[^0-9.]*'would have been cleaner than
git describe --match='*[0-9.][0-9.][0-9.]'but
--excludeis not supported in git version 1.8.3.1, the version used in CentOS 7 currently.