This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Improve TP Tenant Selection #6623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamrickus
added
improvement
ocket8888
reviewed
Mar 7, 2022
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Mar 17, 2022
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.d.ts
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.d.ts
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
...ic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.Steering.tpl.html
Outdated
Show resolved
Hide resolved
shamrickus
force-pushed
the
tp/tenant-select
branch
from
c8b9187 to
993107e
Compare
shamrickus
force-pushed
the
tp/tenant-select
branch
from
993107e to
1c7a789
Compare
ocket8888
reviewed
Mar 29, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
I didn't realize that prerequisites file already had mixed indentation. I just looked near the top and saw tabs. It's still a bit messy because of that, but thank you for making it be consistent now.
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
…yping-fixes Fix the typings
ocket8888
approved these changes
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6427 and arguably #2980. It creates a new directive that can be used to display hierarchical data similar to tenants, and implements it for all tenant fields. It works as a replacement to the
selectelement. I've attached some screenshots at the end.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
On each of the following pages verify that validation works, and that input actually effects the relevant tenant fields:
Tenants (Add & Edit/View)
Delivery Services (All Types, Add & Edit/View)
User (Add & Edit/View)
User Registration
Origins (Add & Edit/View).
On any page verify that the icons in the drop down are expandable/collapsable, the search box implements a basic fuzzy search, the tooltip works and is position correctly + makes sense, and verify that the input works on all supported TP resolutions.
PR submission checklist
Screenshots