This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 351
Allow 0 commits between latest release tag and release branch head #6329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Drafting, we also need a different cache key for the ATS RPM when a tag is pushed but the commit stays the same. We have cached, but now that |
when the _fetch-github-branch-sha_ GitHub Action is modified
Member
Author
|
Undrafted, it includes the latest tag on the ATS release branch in the ATS RPM cache key now. |
Member
Author
|
The |
4 tasks
rawlinp
approved these changes
Nov 4, 2021
This was referenced Nov 4, 2021
Merged
Merged
zrhoffman
added a commit
that referenced
this pull request
Nov 5, 2021
…6329) * Allow 0 commits between latest release tag and release branch head * Use jq for JSON filtering * Cache ATS RPMs by latest ATS branch tag and latest branch commit * Convert to composite action * Trigger _CDN-in-a-Box CI_ and _Cache Config integration tests_ workflows when the _fetch-github-branch-sha_ GitHub Action is modified * Install nodejs by URL until nodesource repo is fixed (cherry picked from commit 2c67dba)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
automation
related to automated testing/deployment/packaging etc.
bug
something isn't working as intended
cdn-in-a-box
related to the Docker-based CDN-in-a-Box system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case in the
infrastructure/cdn-in-a-box/bin/ats-version.shscript, used to calculate the version string of the ATS RPM used by CDN in a Box. What the error looked like in the log formake cache/trafficserver.rpm:cp -f "../../dist/trafficserver-.el8.x86_64.rpm" "cache/trafficserver.rpm" || (rm ".//cache/ATS_VERSION"; false) cp: cannot stat '../../dist/trafficserver-.el8.x86_64.rpm': No such file or directoryWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Check if the
ciab-buildGitHub Action completes successfullyIf this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist