Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Nov 3, 2021

This PR fixes an edge case in the infrastructure/cdn-in-a-box/bin/ats-version.sh script, used to calculate the version string of the ATS RPM used by CDN in a Box. What the error looked like in the log for make cache/trafficserver.rpm:

 cp -f "../../dist/trafficserver-.el8.x86_64.rpm" "cache/trafficserver.rpm" || (rm ".//cache/ATS_VERSION"; false)
cp: cannot stat '../../dist/trafficserver-.el8.x86_64.rpm': No such file or directory

Which Traffic Control components are affected by this PR?

  • CDN in a Box
    • Automation (GitHub Actions)

What is the best way to verify this PR?

Check if the ciab-build GitHub Action completes successfully

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Nov 3, 2021
@zrhoffman zrhoffman marked this pull request as draft November 3, 2021 22:36
@zrhoffman
Copy link
Member Author

Drafting, we also need a different cache key for the ATS RPM when a tag is pushed but the commit stays the same. We have

trafficserver-8.1.1-67.bbbf80d75.el8.x86_64.rpm

cached, but now that 8.1.3 is tagged, it should be

trafficserver-8.1.3-0.bbbf80d75.el8.x86_64.rpm

@zrhoffman zrhoffman marked this pull request as ready for review November 3, 2021 23:32
@zrhoffman
Copy link
Member Author

Undrafted, it includes the latest tag on the ATS release branch in the ATS RPM cache key now.

@zrhoffman
Copy link
Member Author

The trafficportal image fails to build in the Build CDN-in-a-Box images of the ciab-build GHA due to nodesource/distributions#1290:

#7 16.24 [MIRROR] nodejs-12.22.7-1nodesource.x86_64.rpm: Downloading successful, but checksum doesn't match. Calculated: 97450e8d786f1b501f30fbba55b5c2ab52ffedd9(sha1)  Expected: a48c6ab7b1596d6a44ff10a7cffe2fe2cb22dbe7(sha1) 

@zrhoffman zrhoffman added the automation related to automated testing/deployment/packaging etc. label Nov 4, 2021
@rawlinp rawlinp merged commit 2c67dba into apache:master Nov 4, 2021
@zrhoffman zrhoffman deleted the 0-commits branch November 4, 2021 17:01
@zrhoffman zrhoffman added this to the 6.0.1 milestone Nov 5, 2021
zrhoffman added a commit that referenced this pull request Nov 5, 2021
…6329)

* Allow 0 commits between latest release tag and release branch head

* Use jq for JSON filtering

* Cache ATS RPMs by latest ATS branch tag and latest branch commit

* Convert to composite action

* Trigger _CDN-in-a-Box CI_ and _Cache Config integration tests_ workflows
when the _fetch-github-branch-sha_ GitHub Action is modified

* Install nodejs by URL until nodesource repo is fixed

(cherry picked from commit 2c67dba)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants