This repository was archived by the owner on Nov 24, 2025. It is now read-only.
allow spaces in server interface router port name #6260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
Traffic Portal v1
srijeet0406
approved these changes
Oct 7, 2021
Contributor
srijeet0406
left a comment
srijeet0406
left a comment
There was a problem hiding this comment.
Code changes look good.
Manually tested and made sure that I could pass in port names with spaces.
ocket8888
force-pushed
the
tp/fix-router-portname-restriction
branch
from
b5717cc to
21afcc5
Compare
zrhoffman
pushed a commit
that referenced
this pull request
Oct 8, 2021
(cherry picked from commit 21ae341)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6259
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Start Traffic Portal, make sure you can create a server with a space in its router port name for one or more server interfaces
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist