Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Compile ToDnssecRefresh binary into TO rpm, update cron job to use it #6224

Merged
ocket8888 merged 1 commit into from
Sep 21, 2021
Merged

Compile ToDnssecRefresh binary into TO rpm, update cron job to use it #6224

ocket8888 merged 1 commit into from
Sep 21, 2021

Conversation

@rawlinp
Copy link
Contributor

@rawlinp rawlinp commented Sep 17, 2021

Closes: #6179

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Ensure the TO rpm builds and installs successfully. Build and run cdn-in-a-box, then docker exec -it <container> bash to ensure that the cron job exists at /etc/cron.d/trafops_dnssec_refresh with its new contents. Run /opt/traffic_ops/app/bin/checks/DnssecRefresh/ToDnssecRefresh --traffic-ops-url https://trafficops.infra.ciab.test --traffic-ops-user admin --traffic-ops-password twelve12 and ensure that it completes successfully. View the Traffic Ops logs to see that it got the request and handled it (search for refresh).

PR submission checklist

  • Since this PR just updates a cron job and the TO rpm build, no new tests are necessary
  • Since this PR just updates a cron job and the TO rpm build, no new docs are necessary
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rawlinp rawlinp added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. labels Sep 17, 2021
@ocket8888 ocket8888 merged commit 23ee354 into apache:master Sep 21, 2021
@rawlinp rawlinp deleted the go-dnssec-refresh-script branch September 21, 2021 20:34
@zrhoffman zrhoffman added this to the 6.0.0 milestone Sep 21, 2021
zrhoffman pushed a commit that referenced this pull request Sep 21, 2021
@rawlinp @zrhoffman
Compile ToDnssecRefresh binary into TO rpm, update cron job to use it (…
c97f45a 
…#6224)

Closes: #6179
(cherry picked from commit 23ee354)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ocket8888 ocket8888 ocket8888 approved these changes

@Ayushsunny Ayushsunny Ayushsunny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

The DNSSEC refresh cron job still uses the Perl version

4 participants

@rawlinp @ocket8888 @Ayushsunny @zrhoffman