This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix TP Delivery Service form field validation for httpBypassFqdn #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawlinp
approved these changes
Aug 29, 2018
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
the new form validation works
rawlinp
added
bug
Member
|
@saoyag001 @rawlinp for future PRs, can you describe the change in the title rather than the issue # ? Note the issue in the description as you've done, but give the title something that'll be meaningful without having to look up the issue a year down the road |
rawlinp
changed the title
Contributor
|
+1, edited the title and description to be more descriptive of the issue. |
Contributor
Author
|
Tested in staging. Works as designed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The TP field validation currently requires httpBypassFqdn to start with
http://orhttps://, but the field is an FQDN not a URL. This PR fixes that form validation to verify it's an FQDN.Fixes #2768
Which TC components are affected by this PR?
What is the best way to verify this PR?
Add a bypass FQDN to a http delivery service.
Check all that apply