Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

DS SSL keys routes return empty 'response' objects on error #4393

@ocket8888

Description

@ocket8888

I'm submitting a ...

  • bug report
  • improvement request (usability, performance, tech debt, etc.)

(not sure which this would be considered)

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

When Traffic Vault has no keys for a Delivery Service but its keys are requested via /deliveryservices/xmlid/{{XMLID}}/sslkeys or /deliveryservices/hostname/{{hostname}}/sslkeys, Traffic Ops responds with a 200 OK response with a payload similar to:

{
	"alerts": [{
		"level": "info",
		"text": "No objects for MyXMLID"
	}],
	"response": {}
}

Expected / new behavior:

#3534 will change the response code to a more appropriate 404 Not Found and changes the Alert Level to error (I'm pretty sure), but doesn't change the response structure for backward compatibility reasons. For consistency, the response body should contain only the alerts key, because that's what everything else does.

Minimal reproduction of the problem with instructions:

Request SSL keys for a Delivery Service that has no SSL Keys stored in Traffic Vault using a GET request to either /deliveryservices/xmlid/{{XMLID}}/sslkeys or /deliveryservices/hostname/{{hostname}}/sslkeys.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Traffic Opsrelated to Traffic OpsimprovementThe functionality exists but it could be improved in some way.low difficultythe estimated level of effort to resolve this issue is lowlow impactaffects only a small portion of a CDN, and cannot itself break one

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions