#2770: Add validation for httpBypassFqdn as hostname in Traffic Ops (#6330)

qtweng · web-flow · commit 44f2f448c4d6 · 2021-11-04T11:29:30.000-06:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ## [unreleased]
 ### Added
+- [#2770](https://github.com/apache/trafficcontrol/issues/2770) Added validation for httpBypassFqdn as hostname in Traffic Ops
 - Added permission based roles for better access control.
 - [#5674](https://github.com/apache/trafficcontrol/issues/5674) Added new query parameters `cdn` and `maxRevalDurationDays` to the `GET /api/x/jobs` Traffic Ops API to filter by CDN name and within the start_time window defined by the `maxRevalDurationDays` GLOBAL profile parameter, respectively.
 - Added a new Traffic Ops cdn.conf option -- `disable_auto_cert_deletion` -- in order to optionally prevent the automatic deletion of certificates for delivery services that no longer exist whenever a CDN snapshot is taken.
diff --git a/traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go b/traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
@@ -1345,6 +1345,7 @@ func Validate(tx *sql.Tx, ds *tc.DeliveryServiceV4) error {
 		"dscp":                validation.Validate(ds.DSCP, validation.NotNil, validation.Min(0)),
 		"geoLimit":            validation.Validate(ds.GeoLimit, validation.NotNil),
 		"geoProvider":         validation.Validate(ds.GeoProvider, validation.NotNil),
+		"httpByPassFqdn":      validation.Validate(ds.HTTPBypassFQDN, isDNSName),
 		"logsEnabled":         validation.Validate(ds.LogsEnabled, validation.NotNil),
 		"regionalGeoBlocking": validation.Validate(ds.RegionalGeoBlocking, validation.NotNil),
 		"remapText":           validation.Validate(ds.RemapText, noLineBreaks),
