TINKERPOP-2855 Refactored strategy application#2026
Merged
spmallette merged 1 commit into3.5-devfrom Apr 20, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #2026 +/- ##
=============================================
- Coverage 69.36% 64.16% -5.21%
=============================================
Files 866 25 -841
Lines 41227 3750 -37477
Branches 5434 0 -5434
=============================================
- Hits 28598 2406 -26192
+ Misses 10714 1166 -9548
+ Partials 1915 178 -1737 see 841 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
spmallette
force-pushed
the
TINKERPOP-2855
branch
from
18067b2 to
98e9e9a
Compare
lyndonbauto
reviewed
Apr 19, 2023
| return result; | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Nit - add new line.
Suggested change
| } | |
| } | |
Contributor
|
VOTE+1 Reviewed code and tried this change locally on Aerospike Graph. I had a query that was heavy on coalesce use and found that strategies were taking ~120 ms on this specific query for my local system. This change dropped the time to apply strategies to 10 ms. |
lyndonbauto
approved these changes
Apr 19, 2023
Removed some recursion. Added Traversal.lock() to offer a formal way to finalize a traversal. Offers a significant performance improvement. Removed expectation that Graph and related metadata for a Traversal is available in child traversals
spmallette
force-pushed
the
TINKERPOP-2855
branch
from
98e9e9a to
d5efc02
Compare
Contributor
|
VOTE+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2855
https://issues.apache.org/jira/browse/TINKERPOP-2888
Removed some recursion. Added
Traversal.lock()to offer a formal way to finalize a traversal. Offers a significant performance improvement. Removed expectation that Graph and related metadata for aTraversalis available in child traversals.On TINKERPOP-2855 the script demonstrating the slowdown was running at 9.1 seconds on my system for 3.5.5. With this change it is executing at 1.7 seconds.
VOTE +1