fix flaky tests in ParametersTest (#2820)

qz0610 · Cole-Greer · commit 2d6814a123e9 · 2024-10-17T15:12:07.000-07:00
diff --git a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/util/ParametersTest.java b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/util/ParametersTest.java
@@ -28,6 +28,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import java.util.HashMap;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -57,7 +58,15 @@ public void shouldAllowNullValues() {
 
         final Object[] params = parameters.getKeyValues(mock(Traverser.Admin.class));
         assertEquals(6, params.length);
-        assertThat(Arrays.equals(new Object[] {"a", null, "b", "bat", "c", "cat"}, params), is(true));
+        Map<Object, Object> paramsMap = new HashMap<>();
+        for (int i = 0; i < params.length; i += 2) {
+            paramsMap.put(params[i], params[i + 1]);
+        }
+        Map<Object, Object> expectedMap = new HashMap<>();
+        expectedMap.put("a", null);
+        expectedMap.put("b", "bat");
+        expectedMap.put("c", "cat");
+        assertThat(paramsMap.equals(expectedMap), is(true));
     }
 
     @Test
@@ -67,7 +76,15 @@ public void shouldGetKeyValues() {
 
         final Object[] params = parameters.getKeyValues(mock(Traverser.Admin.class));
         assertEquals(6, params.length);
-        assertThat(Arrays.equals(new Object[] {"a", "axe", "b", "bat", "c", "cat"}, params), is(true));
+        Map<Object, Object> paramsMap = new HashMap<>();
+        for (int i = 0; i < params.length; i += 2) {
+            paramsMap.put(params[i], params[i + 1]);
+        }
+        Map<Object, Object> expectedMap = new HashMap<>();
+        expectedMap.put("a", "axe");
+        expectedMap.put("b", "bat");
+        expectedMap.put("c", "cat");
+        assertThat(paramsMap.equals(expectedMap), is(true));
     }
 
     @Test
@@ -77,7 +94,14 @@ public void shouldGetKeyValuesIgnoringSomeKeys() {
 
         final Object[] params = parameters.getKeyValues(mock(Traverser.Admin.class), "b");
         assertEquals(4, params.length);
-        assertThat(Arrays.equals(new Object[] {"a", "axe", "c", "cat"}, params), is(true));
+        Map<Object, Object> paramsMap = new HashMap<>();
+        for (int i = 0; i < params.length; i += 2) {
+            paramsMap.put(params[i], params[i + 1]);
+        }
+        Map<Object, Object> expectedMap = new HashMap<>();
+        expectedMap.put("a", "axe");
+        expectedMap.put("c", "cat");
+        assertThat(paramsMap.equals(expectedMap), is(true));
     }
 
     @Test
