Skip to content

fix(deps, ci, v1.3): bump sbt/setup-sbt to v1.5.14 to restore CI - #9355

Merged
mengw15 merged 1 commit into
release/v1.3from
backport/9346-bump-sbt-setup-sbt-to-v1-5-14-to-restore-v1.3
Nov 6, 2026
Merged

mengw15 merged 1 commit into
release/v1.3from
backport/9346-bump-sbt-setup-sbt-to-v1-5-14-to-restore-v1.3

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Automated backport of #9346 to release/v1.3.

Source: c6a4645 · automation run

Any related issues, documentation, discussions?

Backport of #9346. Originally linked #9345.

How was this PR tested?

The backported tree built green before #9346 merged. Release-branch CI runs on this PR once it is reopened — see the comment below.

Was this PR authored or co-authored using generative AI tooling?

No.

### What changes were proposed in this PR?

Nothing can merge into main right now. Every job that sets up sbt
(`amber`, `amber-integration`, `platform` ×6, `platform-integration` ×6,
`Bench`, the image builds and the dependency graph) has died at `Setup
sbt launcher` since 2026-11-05 15:36 UTC, on main itself and on every
PR, so `Required Checks` is red and the merge queue takes nothing.
Nothing in this repository changed: main at `312a0cefc` (#9325, run at
07:16 UTC) was green, main at `8b0fb168e` (#8848, run at 20:54 UTC) is
red, and that commit touches three frontend files.

Before: Scala job -> sbt/setup-sbt v1.5.12 -> "Verify the sbt
distribution signature" reads carabiner-dev/policies at HEAD -> ampel
v1.3.6 cannot parse it -> exit 1 before sbt is installed
After: Scala job -> sbt/setup-sbt v1.5.14 -> the same step reads the
policy pinned at carabiner-dev/policies@971d670e9 -> sbt installs -> the
job runs

Root cause. v1.5.12 hands `carabiner-dev/actions/ampel/verify@32587e8`
(ampel v1.3.6) the policy argument
`git+https://github.com/carabiner-dev/policies#signature/signature.json`,
with no ref, so the policy is whatever that repository's main holds at
run time. On 2026-11-05 `signature/signature.json` gained a `meta.name`
field that ampel v1.3.6 rejects, and ampel exits while loading the
policy with `compiling policy: unable to parse a policy, group or
policySet from data`. The step's `fail: false` covers a failed
verification verdict, not the loader exiting, so the composite action
fails and the job stops. sbt/setup-sbt#155, released as v1.5.14 the same
day, pins the policy to
`carabiner-dev/policies@971d670e93f2fb4da304b0e5f071066dc4686a5a`, a
commit without the field.

Change. All 9 call sites (`build.yml` ×4, `build-and-push-images.yml`
×3, `benchmarks.yml`, `dependency-graph.yml`) move from
`ecad189dd245444b9ae0a0cd5922fd938b88906f` (v1.5.12) to
`67d461eba2c4753196c230e02da850757ba4775e` (v1.5.14), as #9100 moved
them to v1.5.12. Between the two versions `action.yml` differs in two
lines: the policy pin above and the default `sbt-runner-version` (2.0.10
-> 2.0.12), which this repository does not use because
`project/build.properties` sets `sbt.version`. The nested actions,
`actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9` and
`carabiner-dev/actions/ampel/verify@32587e82f960d49b36101e8c45d1956e511965d3`,
are the same in both, and no call site passes inputs.

Scope. v1.5.13 is already on the ASF allow list but carries the same
unpinned policy line, so it fails the same way; v1.5.14 is the first
version that does not. This PR changes nothing about what the signature
step does when it runs; it only stops the step from reading a moving
target.

**Blocked on apache/infrastructure-actions#1498.**
`sbt/setup-sbt@67d461eba` is not on the ASF actions allow list yet;
#1498 (opened 2026-11-05 13:39 UTC) adds it. Until it merges, every sbt
job on this PR fails at `Set up job` with the action not allowed, which
is how v1.5.7 failed in #9100, so the red checks here are expected and
this PR must not be merged before #1498 lands. Once it does, a re-run of
the failed jobs is the proof; nothing in this branch needs to change.

### Any related issues, documentation, discussions?

Closes #9345.

Upstream fix: sbt/setup-sbt#155 (v1.5.14). Allow-list entry:
apache/infrastructure-actions#1498. Precedent: #9100 moved the same 9
call sites to v1.5.12 after the ASF allow list dropped the actions
v1.5.7 reached, with backports #9132 (v1.3) and #9133 (v1.2); #7710 and
#6990 are the earlier bumps of the same kind.

### How was this PR tested?

Every changed file parses:

```
python -I -c "import sys, yaml; [yaml.safe_load(open(f, encoding='utf-8')) for f in sys.argv[1:]]" .github/workflows/build.yml .github/workflows/build-and-push-images.yml .github/workflows/benchmarks.yml .github/workflows/dependency-graph.yml
```

`git ls-remote --tags https://github.com/sbt/setup-sbt.git` resolves
`refs/tags/v1.5.14^{}` to `67d461eba2c4753196c230e02da850757ba4775e`.
Diffing `action.yml` at `ecad189` against `67d461eba` shows only the two
lines described above, with identical `uses:` lines. Walking the `uses:`
chain under v1.5.14 reaches `ampel/verify@32587e8`, which is in
`apache/infrastructure-actions` `approved_patterns.yml`;
`sbt/setup-sbt@67d461eba` itself is not yet, which
apache/infrastructure-actions#1498 adds.

The rest is CI. The labeler applies `ci` for `.github/**`, which runs
every stack that sets up sbt. Those jobs cannot pass until
apache/infrastructure-actions#1498 lands (see above); the re-run after
that is the test, and the checks on this PR are the first run of v1.5.14
in this repository.

### Was this PR authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Code (claude-fable-5-1). Co-authored with
Claude; the author reviewed the change before submission.

(backported from commit c6a4645)
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Clean cherry-pick — nothing here was edited by hand. It applied to release/v1.3 without conflicts, and the backported tree built green before #9346 merged.

Close this PR and reopen it to start its required checks. This pull request was opened by github-actions[bot], and GitHub starts no workflow run for anything the Actions token does, so it has no checks yet. Reopening it (or pushing any commit to the branch) emits the event they subscribe to. Marking it ready for review will not — none of the three required workflows listen for that.

After that: approve, and enable auto-merge if you would rather not come back when the checks finish.

@mengw15 mengw15 closed this Nov 6, 2026
@mengw15 mengw15 reopened this Nov 6, 2026
@github-actions github-actions Bot added the ci changes related to CI label Nov 6, 2026
@mengw15
mengw15 enabled auto-merge November 6, 2026 22:10
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @mengw15
    You can notify them by mentioning @mengw15 in a comment.

@codecov-commenter

codecov-commenter commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.83%. Comparing base (1f49297) to head (c3e7122).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.3    #9355      +/-   ##
==================================================
- Coverage           93.83%   93.83%   -0.01%     
+ Complexity           4767     4766       -1     
==================================================
  Files                1190     1190              
  Lines               48463    48463              
  Branches             5858     5858              
==================================================
- Hits                45476    45474       -2     
- Misses               1538     1539       +1     
- Partials             1449     1450       +1     
Flag Coverage Δ
access-control-service 81.00% <ø> (ø)
agent-service 99.33% <ø> (ø)
amber 89.35% <ø> (-0.02%) ⬇️
computing-unit-managing-service 73.67% <ø> (ø)
config-service 87.00% <ø> (ø)
file-service 86.32% <ø> (ø)
frontend 96.89% <ø> (ø)
notebook-migration-service 79.31% <ø> (ø)
pyamber 98.18% <ø> (ø)
workflow-compiling-service 77.58% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Benchmark changes need a look

🟢 0 better · 🔴 8 worse · ⚪ 7 noise (<±5%) · 0 without baseline

Compared against main 1f49297 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🔴 bs=10 sw=10 sl=64 686 0.419 12,923/20,830/20,830 us 🔴 -6.2% / 🔴 +61.6%
🔴 bs=100 sw=10 sl=64 1,627 0.993 58,156/85,968/85,968 us 🔴 +12.3% / 🟢 +31.0%
🔴 bs=1000 sw=10 sl=64 1,946 1.188 502,516/615,611/615,611 us 🔴 +8.7% / 🟢 +52.5%
Baseline details

Latest main 1f49297 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 686 tuples/sec 731 tuples/sec 953.99 tuples/sec -6.2% -28.1%
bs=10 sw=10 sl=64 MB/s 0.419 MB/s 0.446 MB/s 0.582 MB/s -6.1% -28.0%
bs=10 sw=10 sl=64 p50 12,923 us 12,625 us 10,584 us +2.4% +22.1%
bs=10 sw=10 sl=64 p95 20,830 us 20,519 us 12,888 us +1.5% +61.6%
bs=10 sw=10 sl=64 p99 20,830 us 20,519 us 16,266 us +1.5% +28.1%
bs=100 sw=10 sl=64 throughput 1,627 tuples/sec 1,720 tuples/sec 1,242 tuples/sec -5.4% +31.0%
bs=100 sw=10 sl=64 MB/s 0.993 MB/s 1.05 MB/s 0.758 MB/s -5.4% +31.0%
bs=100 sw=10 sl=64 p50 58,156 us 57,276 us 83,370 us +1.5% -30.2%
bs=100 sw=10 sl=64 p95 85,968 us 76,532 us 88,966 us +12.3% -3.4%
bs=100 sw=10 sl=64 p99 85,968 us 76,532 us 101,186 us +12.3% -15.0%
bs=1000 sw=10 sl=64 throughput 1,946 tuples/sec 2,024 tuples/sec 1,276 tuples/sec -3.9% +52.5%
bs=1000 sw=10 sl=64 MB/s 1.188 MB/s 1.235 MB/s 0.779 MB/s -3.8% +52.5%
bs=1000 sw=10 sl=64 p50 502,516 us 489,631 us 815,662 us +2.6% -38.4%
bs=1000 sw=10 sl=64 p95 615,611 us 566,395 us 864,800 us +8.7% -28.8%
bs=1000 sw=10 sl=64 p99 615,611 us 566,395 us 896,884 us +8.7% -31.4%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,291.50,200,128000,686,0.419,12922.61,20830.00,20830.00
1,100,10,64,20,1229.50,2000,1280000,1627,0.993,58156.08,85968.47,85968.47
2,1000,10,64,20,10275.99,20000,12800000,1946,1.188,502516.38,615610.81,615610.81

@mengw15
mengw15 added this pull request to the merge queue Nov 6, 2026
Merged via the queue into release/v1.3 with commit e90d62f Nov 6, 2026
40 checks passed
@mengw15
mengw15 deleted the backport/9346-bump-sbt-setup-sbt-to-v1-5-14-to-restore-v1.3 branch November 6, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants