Skip to content

fix(deps, ci, v1.3): bump setup-sbt and playwright - #9132

Merged
mengw15 merged 1 commit into
apache:release/v1.3from
mengw15:fix/9095-bump-setup-sbt-and-playwright-v1.3
Oct 25, 2026
Merged

mengw15 merged 1 commit into
apache:release/v1.3from
mengw15:fix/9095-bump-setup-sbt-and-playwright-v1.3

Conversation

@mengw15

@mengw15 mengw15 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Backport of #9100 to release/v1.3, which it never reached because it had no release/v1.3 label. The ASF actions allowlist dropped the nested carabiner-dev action that sbt/setup-sbt v1.5.7 uses, so every job here that sets up sbt fails at Set up job (see #9130), and so does the image build in build-and-push-images.yml. The ubuntu frontend leg also needs Playwright 1.64.1 on the Ubuntu 26.04 runners.

The cherry-pick applies cleanly: all 9 sbt/setup-sbt call sites move to v1.5.12, and playwright moves to 1.64.1.

Any related issues, documentation, discussions?

Backport of #9100. Originally linked #9095.

How was this PR tested?

yarn install --mode=update-lockfile leaves yarn.lock unchanged, and this PR's own CI runs on the updated workflows.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-5-5)

### What changes were proposed in this PR?

Nothing can merge into `main` right now. Three CI faults block it, and
each fix needs the others to land first.

```
Before:  Scala job     -> sbt/setup-sbt v1.5.7  -> nested carabiner action not allowed -> fails at Set up job
         frontend job  -> ubuntu-26.04 runner   -> Playwright 1.59.1 has no Chromium    -> fails at install
         merge group   -> no runner within 45 min                -> checks_timed_out, PR leaves the queue
After:   Scala job     -> sbt/setup-sbt v1.5.12 -> every nested action allowed         -> runs
         frontend job  -> ubuntu-26.04 runner   -> Playwright 1.64.1 installs Chromium  -> runs
         merge group   -> waits up to 360 min for runners         -> merges
```

- **setup-sbt.** The ASF actions allowlist dropped the nested
`carabiner-dev/actions/install/*` refs that `sbt/setup-sbt` v1.5.7
reaches, so every job that sets up sbt (`amber`, `amber-integration`,
`platform`, `platform-integration`, `Bench`) has died at *Set up job*
since 2026-10-19. This moves all 9 call sites to v1.5.12, whose whole
chain is allowed. The action's inputs did not change.
- **Playwright.** `ubuntu-latest` now resolves to the Ubuntu 26.04
image, where Playwright 1.59.1 refuses to install Chromium ("Playwright
does not support chromium on ubuntu26.04-x64"), so the ubuntu frontend
leg fails before any test runs. This bumps `playwright` to 1.64.1, which
supports 26.04.
- **Merge queue timeout.** The queue ejects an entry whose required
checks have not reported within `check_response_timeout_minutes`, which
is 45. ASF's shared runners are backed up well past that: in the last
merge group, *Validate PR title*, a 2-second job, waited 110 minutes for
a runner. This raises the limit to 360 minutes, as DataFusion did in
apache/datafusion#26293.

`Required Checks` stays red without both version bumps, and no PR gets
through the queue without the higher limit, so all three go in one PR.

### Any related issues, documentation, discussions?

Closes apache#9095.

### How was this PR tested?

Every changed file parses:

```
python -I -c "import sys, yaml; [yaml.safe_load(open(f)) for f in sys.argv[1:]]" .asf.yaml .github/workflows/benchmarks.yml .github/workflows/build-and-push-images.yml .github/workflows/build.yml .github/workflows/dependency-graph.yml
```

Walking the `uses:` chain under `sbt/setup-sbt@ecad189` (v1.5.12)
reaches `ampel/verify@32587e8`, `install/ampel@d6d91c5`,
`install/download-and-verify@2fec8bd` and
`install/ampel-bootstrap@16009dc`, and all four are in
`apache/infrastructure-actions`' `approved_patterns.yml` as of
2026-10-23. Under v1.5.7, `install/ampel@2fec8bd`,
`install/download-and-verify@16009dc` and
`install/ampel-bootstrap@619a474` are not.

The rest is CI. The labeler applies `ci` for `.github/**`, which runs
every stack that sets up sbt, the frontend legs, and `Bench`. On this
PR's previous head every job passed except the ubuntu frontend leg,
which landed on ubuntu-26.04 and failed at the Playwright install. The
new timeout only shows once this is merged.

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Ian Maxon <[email protected]>
@mengw15
mengw15 requested a review from aglinxinyuan October 25, 2026 02:54
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file fix frontend Changes related to the frontend GUI ci changes related to CI labels Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @aglinxinyuan, @zyratlo
    You can notify them by mentioning @aglinxinyuan, @zyratlo in a comment.

@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.09%. Comparing base (7df76e6) to head (35d774d).

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.3    #9132      +/-   ##
==================================================
- Coverage           94.10%   94.09%   -0.01%     
  Complexity           4810     4810              
==================================================
  Files                1194     1194              
  Lines               48625    48625              
  Branches             5864     5864              
==================================================
- Hits                45759    45756       -3     
- Misses               1412     1414       +2     
- Partials             1454     1455       +1     
Flag Coverage Δ *Carryforward flag
access-control-service 81.00% <ø> (ø)
agent-service 99.32% <ø> (ø)
amber 90.11% <ø> (ø) Carriedforward from 7df76e6
computing-unit-managing-service 73.67% <ø> (ø)
config-service 87.00% <ø> (ø)
file-service 87.75% <ø> (ø)
frontend 96.89% <ø> (ø) Carriedforward from 7df76e6
notebook-migration-service 79.31% <ø> (ø)
pyamber 98.12% <ø> (-0.07%) ⬇️
workflow-compiling-service 77.19% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 0 better · 🔴 5 worse · ⚪ 10 noise (<±5%) · 0 without baseline

Compared against main 7df76e6 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🔴 bs=10 sw=10 sl=64 571 0.349 17,845/22,994/22,994 us 🔴 +33.6% / 🔴 +61.5%
🔴 bs=100 sw=10 sl=64 1,551 0.947 62,290/75,891/75,891 us 🔴 -5.3% / 🟢 +35.2%
⚪ bs=1000 sw=10 sl=64 1,943 1.186 505,428/644,881/644,881 us ⚪ within ±5% / 🟢 +64.4%
Baseline details

Latest main 7df76e6 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 571 tuples/sec 657 tuples/sec 879.16 tuples/sec -13.1% -35.1%
bs=10 sw=10 sl=64 MB/s 0.349 MB/s 0.401 MB/s 0.537 MB/s -13.0% -35.0%
bs=10 sw=10 sl=64 p50 17,845 us 13,358 us 11,504 us +33.6% +55.1%
bs=10 sw=10 sl=64 p95 22,994 us 23,935 us 14,234 us -3.9% +61.5%
bs=10 sw=10 sl=64 p99 22,994 us 23,935 us 17,338 us -3.9% +32.6%
bs=100 sw=10 sl=64 throughput 1,551 tuples/sec 1,637 tuples/sec 1,147 tuples/sec -5.3% +35.2%
bs=100 sw=10 sl=64 MB/s 0.947 MB/s 0.999 MB/s 0.7 MB/s -5.2% +35.2%
bs=100 sw=10 sl=64 p50 62,290 us 59,371 us 88,987 us +4.9% -30.0%
bs=100 sw=10 sl=64 p95 75,891 us 73,050 us 96,473 us +3.9% -21.3%
bs=100 sw=10 sl=64 p99 75,891 us 73,050 us 102,791 us +3.9% -26.2%
bs=1000 sw=10 sl=64 throughput 1,943 tuples/sec 1,988 tuples/sec 1,182 tuples/sec -2.3% +64.4%
bs=1000 sw=10 sl=64 MB/s 1.186 MB/s 1.213 MB/s 0.721 MB/s -2.2% +64.4%
bs=1000 sw=10 sl=64 p50 505,428 us 499,537 us 872,751 us +1.2% -42.1%
bs=1000 sw=10 sl=64 p95 644,881 us 642,543 us 910,151 us +0.4% -29.1%
bs=1000 sw=10 sl=64 p99 644,881 us 642,543 us 941,479 us +0.4% -31.5%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,350.20,200,128000,571,0.349,17844.84,22993.76,22993.76
1,100,10,64,20,1289.30,2000,1280000,1551,0.947,62290.14,75890.93,75890.93
2,1000,10,64,20,10295.03,20000,12800000,1943,1.186,505427.75,644881.38,644881.38

@xuang7 xuang7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengw15
mengw15 enabled auto-merge October 25, 2026 03:19
@mengw15
mengw15 added this pull request to the merge queue Oct 25, 2026
Merged via the queue into apache:release/v1.3 with commit d234118 Oct 25, 2026
66 of 68 checks passed
@mengw15
mengw15 deleted the fix/9095-bump-setup-sbt-and-playwright-v1.3 branch October 25, 2026 03:39
renovate-bot pushed a commit to renovate-bot/apache-_-texera that referenced this pull request Nov 6, 2026
### What changes were proposed in this PR?

Nothing can merge into main right now. Every job that sets up sbt
(`amber`, `amber-integration`, `platform` ×6, `platform-integration` ×6,
`Bench`, the image builds and the dependency graph) has died at `Setup
sbt launcher` since 2026-11-05 15:36 UTC, on main itself and on every
PR, so `Required Checks` is red and the merge queue takes nothing.
Nothing in this repository changed: main at `312a0cefc` (apache#9325, run at
07:16 UTC) was green, main at `8b0fb168e` (apache#8848, run at 20:54 UTC) is
red, and that commit touches three frontend files.

Before: Scala job -> sbt/setup-sbt v1.5.12 -> "Verify the sbt
distribution signature" reads carabiner-dev/policies at HEAD -> ampel
v1.3.6 cannot parse it -> exit 1 before sbt is installed
After: Scala job -> sbt/setup-sbt v1.5.14 -> the same step reads the
policy pinned at carabiner-dev/policies@971d670e9 -> sbt installs -> the
job runs

Root cause. v1.5.12 hands `carabiner-dev/actions/ampel/verify@32587e8`
(ampel v1.3.6) the policy argument
`git+https://github.com/carabiner-dev/policies#signature/signature.json`,
with no ref, so the policy is whatever that repository's main holds at
run time. On 2026-11-05 `signature/signature.json` gained a `meta.name`
field that ampel v1.3.6 rejects, and ampel exits while loading the
policy with `compiling policy: unable to parse a policy, group or
policySet from data`. The step's `fail: false` covers a failed
verification verdict, not the loader exiting, so the composite action
fails and the job stops. sbt/setup-sbt#155, released as v1.5.14 the same
day, pins the policy to
`carabiner-dev/policies@971d670e93f2fb4da304b0e5f071066dc4686a5a`, a
commit without the field.

Change. All 9 call sites (`build.yml` ×4, `build-and-push-images.yml`
×3, `benchmarks.yml`, `dependency-graph.yml`) move from
`ecad189dd245444b9ae0a0cd5922fd938b88906f` (v1.5.12) to
`67d461eba2c4753196c230e02da850757ba4775e` (v1.5.14), as apache#9100 moved
them to v1.5.12. Between the two versions `action.yml` differs in two
lines: the policy pin above and the default `sbt-runner-version` (2.0.10
-> 2.0.12), which this repository does not use because
`project/build.properties` sets `sbt.version`. The nested actions,
`actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9` and
`carabiner-dev/actions/ampel/verify@32587e82f960d49b36101e8c45d1956e511965d3`,
are the same in both, and no call site passes inputs.

Scope. v1.5.13 is already on the ASF allow list but carries the same
unpinned policy line, so it fails the same way; v1.5.14 is the first
version that does not. This PR changes nothing about what the signature
step does when it runs; it only stops the step from reading a moving
target.

**Blocked on apache/infrastructure-actions#1498.**
`sbt/setup-sbt@67d461eba` is not on the ASF actions allow list yet;
apache#1498 (opened 2026-11-05 13:39 UTC) adds it. Until it merges, every sbt
job on this PR fails at `Set up job` with the action not allowed, which
is how v1.5.7 failed in apache#9100, so the red checks here are expected and
this PR must not be merged before apache#1498 lands. Once it does, a re-run of
the failed jobs is the proof; nothing in this branch needs to change.

### Any related issues, documentation, discussions?

Closes apache#9345.

Upstream fix: sbt/setup-sbt#155 (v1.5.14). Allow-list entry:
apache/infrastructure-actions#1498. Precedent: apache#9100 moved the same 9
call sites to v1.5.12 after the ASF allow list dropped the actions
v1.5.7 reached, with backports apache#9132 (v1.3) and apache#9133 (v1.2); apache#7710 and
apache#6990 are the earlier bumps of the same kind.

### How was this PR tested?

Every changed file parses:

```
python -I -c "import sys, yaml; [yaml.safe_load(open(f, encoding='utf-8')) for f in sys.argv[1:]]" .github/workflows/build.yml .github/workflows/build-and-push-images.yml .github/workflows/benchmarks.yml .github/workflows/dependency-graph.yml
```

`git ls-remote --tags https://github.com/sbt/setup-sbt.git` resolves
`refs/tags/v1.5.14^{}` to `67d461eba2c4753196c230e02da850757ba4775e`.
Diffing `action.yml` at `ecad189` against `67d461eba` shows only the two
lines described above, with identical `uses:` lines. Walking the `uses:`
chain under v1.5.14 reaches `ampel/verify@32587e8`, which is in
`apache/infrastructure-actions` `approved_patterns.yml`;
`sbt/setup-sbt@67d461eba` itself is not yet, which
apache/infrastructure-actions#1498 adds.

The rest is CI. The labeler applies `ci` for `.github/**`, which runs
every stack that sets up sbt. Those jobs cannot pass until
apache/infrastructure-actions#1498 lands (see above); the re-run after
that is the test, and the checks on this PR are the first run of v1.5.14
in this repository.

### Was this PR authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Code (claude-fable-5-1). Co-authored with
Claude; the author reviewed the change before submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI dependencies Pull requests that update a dependency file fix frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants