Skip to content

refactor(frontend): remove the unused HubWorkflow interface - #9111

Merged
aglinxinyuan merged 2 commits into
apache:mainfrom
aglinxinyuan:refactor/fe-hub-workflow-interface
Oct 26, 2026
Merged

aglinxinyuan merged 2 commits into
apache:mainfrom
aglinxinyuan:refactor/fe-hub-workflow-interface

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes frontend/src/app/hub/component/type/hub-workflow.interface.ts, a type file nothing imports. It is the only file in hub/component/type/, so that directory goes too. −27 lines. There is no behaviour change.

The file exports HubWorkflow. No code, spec, barrel file or path alias references the file or the interface; the similarly named HubWorkflowDetailComponent and HUB_WORKFLOW* route constants are unrelated. No open PR adds an import.

History

Introduced by #2725 (2024-09-24), "Add Hub", for the hub workflow list
Usage removed by #2928 (2024-10-29), "Add landing page", which deleted the components that listed workflows with it. #3252 (2025-02-09) then deleted the last, already unused, importer

It has been unused for the two years since #2928.

Any related issues, documentation, discussions?

Closes #9108

How was this PR tested?

No new tests; nothing referenced the file.

From frontend/:

  • npx tsc --noEmit -p src/tsconfig.app.json and -p src/tsconfig.spec.json: clean.
  • yarn format:ci: clean.
  • npx ng build: success.

To re-check:

git grep -n -w HubWorkflow   # no hits
git grep -n "hub-workflow.interface"   # no hits

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

Nothing has used hub/component/type/hub-workflow.interface.ts since
apache#2928 deleted the hub workflow list components; apache#3252 then removed
its last, already dead, importer. Delete the file.
Copilot AI balanced review requested due to automatic review settings October 23, 2026 21:12
@aglinxinyuan aglinxinyuan self-assigned this Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions github-actions Bot added refactor Refactor the code frontend Changes related to the frontend GUI labels Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.58%. Comparing base (6cfcfb1) to head (a02c0ba).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9111      +/-   ##
============================================
+ Coverage     92.34%   92.58%   +0.24%     
+ Complexity     5046     5029      -17     
============================================
  Files          1261     1260       -1     
  Lines         54117    53715     -402     
  Branches       6767     6700      -67     
============================================
- Hits          49973    49734     -239     
+ Misses         2485     2324     -161     
+ Partials       1659     1657       -2     
Flag Coverage Δ *Carryforward flag
access-control-service 77.38% <ø> (ø) Carriedforward from 2351cb8
agent-service 99.16% <ø> (ø) Carriedforward from 2351cb8
amber 88.07% <ø> (+0.74%) ⬆️ Carriedforward from 2351cb8
computing-unit-managing-service 60.48% <ø> (ø) Carriedforward from 2351cb8
config-service 87.37% <ø> (ø) Carriedforward from 2351cb8
file-service 82.00% <ø> (ø) Carriedforward from 2351cb8
frontend 96.55% <ø> (-0.01%) ⬇️
notebook-migration-service 83.73% <ø> (ø) Carriedforward from 2351cb8
pyamber 98.53% <ø> (-0.05%) ⬇️ Carriedforward from 2351cb8
workflow-compiling-service 72.43% <ø> (ø) Carriedforward from 2351cb8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunwp1
kunwp1 requested a lite review from Copilot October 26, 2026 16:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

Review effort: Lite

@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 26, 2026
Merged via the queue into apache:main with commit 41da9df Oct 26, 2026
24 checks passed
@aglinxinyuan
aglinxinyuan deleted the refactor/fe-hub-workflow-interface branch October 26, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unused HubWorkflow type file

4 participants