Repository navigation
refactor(frontend): remove dead landing page styles - #9069
Merged
aglinxinyuan merged 1 commit intoOct 24, 2026
Merged
Conversation
The landing page template has never used .search-bar or .browse-section (the sections are <texera-browse-section> elements), and apache#4134 removed the only .section-intro-img element with the hub icon. Emulated encapsulation keeps the rules from matching anything else. Delete the three rules.
Contributor
Automated Reviewer SuggestionsBased on the
|
github-actions
Bot
added
refactor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9069 +/- ##
============================================
- Coverage 92.33% 92.33% -0.01%
Complexity 5045 5045
============================================
Files 1261 1261
Lines 54120 54120
Branches 6768 6768
============================================
- Hits 49974 49972 -2
Misses 2486 2486
- Partials 1660 1662 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
Review effort: Lite
kunwp1
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes three rules from the hub landing page's stylesheet that style nothing:
.search-bar,.section-intro-imgand.browse-section. −15 lines. There is no behaviour change.The component uses emulated encapsulation, so these rules can only match its own template. That template uses only
landing-page-container,section-introandsection-intro-text, and has no class bindings or projected content. The browse sections are<texera-browse-section>elements, which the.browse-sectionclass selector doesn't match. The rules for the intro block and its text stay.History
<img class="section-intro-img">hub icon..search-barand.browse-sectionwere never used: no version of the template has had either class.search-barand.browse-sectionhave never applied in the two years since they were added;.section-intro-imghas been dead for nine months.Any related issues, documentation, discussions?
Closes #9066
How was this PR tested?
No new tests; no spec referenced these classes.
From
frontend/:npx ng test --watch=false --include='**/landing-page.component.spec.ts': 17 tests, all pass. No other spec renders the component.yarn format:ci: clean.npx ng build: success.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code