Skip to content

fix(deps, ci, v1.2): bump sbt/setup-sbt to v1.5.2 for ASF actions allowlist - #6990

Merged
Yicong-Huang merged 1 commit into
release/v1.2from
ci/6989-sbt-setup-sbt-v1.5.2-v1.2
Jul 29, 2026
Merged

Yicong-Huang merged 1 commit into
release/v1.2from
ci/6989-sbt-setup-sbt-v1.5.2-v1.2

Conversation

@Yicong-Huang

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

release/v1.2 pins sbt/setup-sbt@508b753e53cb6095967669e0911487d2b9bc9f41 (v1.1.22), which is not on the ASF GitHub Enterprise actions allowlist. GitHub rejects the workflow while building the graph, so the Required Checks workflow ends in startup_failure and no CI runs on release/v1.2 — the precheck job never executes, which is why CI appears to "not trigger by label".

This bumps all 6 pins to the allowlisted version already used on main (green there):

- sbt/setup-sbt@508b753e53cb6095967669e0911487d2b9bc9f41 # v1.1.22
+ sbt/setup-sbt@6444f4c8111de4b9059c3975def104b03cfaa5f0 # v1.5.2
  • .github/workflows/build.yml (×3)
  • .github/workflows/build-and-push-images.yml (×3)

Minimal targeted change rather than backporting the large github-actions group bump (#6187), which touches 15 actions across 17 files and conflicts heavily against v1.2.

Any related issues, documentation, discussions?

Fixes #6989. main reached v1.5.2 via #6710 (d28b761ae). Unblocks backport PRs #6982 and #6984.

How was this PR tested?

This PR's own Required Checks run is the test: because the head branch already uses the allowlisted sbt/setup-sbt@6444f4c8 (v1.5.2), the workflow should now start successfully instead of startup_failure. Diff is limited to the 6 action pins (verified no other 508b753e references remain in .github/workflows/).

Was this PR authored or co-authored using generative AI tooling?

Yes — authored with Claude Code.

🤖 Generated with Claude Code

release/v1.2 pins sbt/setup-sbt@508b753e (v1.1.22), which is not on the
ASF GitHub Enterprise actions allowlist. GitHub rejects the workflow at
graph-build time, so Required Checks ends in startup_failure and no CI
runs on v1.2 (matching main, which already uses v1.5.2 via #6710).

Bump all 6 pins in build.yml and build-and-push-images.yml to the
allowlisted sbt/setup-sbt@6444f4c8 (v1.5.2).

Fixes #6989.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@Yicong-Huang Yicong-Huang added ci changes related to CI release/v1.2 back porting to release/v1.2 and removed release/v1.2 back porting to release/v1.2 labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @bobbai00
    You can notify them by mentioning @bobbai00 in a comment.

@Yicong-Huang Yicong-Huang changed the title ci(v1.2): bump sbt/setup-sbt to v1.5.2 for ASF actions allowlist fix(deps, ci, v1.2): bump sbt/setup-sbt to v1.5.2 for ASF actions allowlist Jul 29, 2026
@codecov-commenter

codecov-commenter commented Jul 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.39%. Comparing base (9a989b4) to head (8f8b398).
⚠️ Report is 2 commits behind head on release/v1.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.2    #6990   +/-   ##
===============================================
  Coverage           52.39%   52.39%           
+ Complexity           2493     2489    -4     
===============================================
  Files                1077     1077           
  Lines               42267    42267           
  Branches             4548     4548           
===============================================
+ Hits                22146    22147    +1     
+ Misses              18815    18810    -5     
- Partials             1306     1310    +4     
Flag Coverage Δ *Carryforward flag
access-control-service 64.61% <ø> (ø)
agent-service 34.36% <ø> (ø)
amber 52.49% <ø> (-0.04%) ⬇️
computing-unit-managing-service 1.65% <ø> (ø)
config-service 56.06% <ø> (ø)
file-service 58.59% <ø> (ø)
frontend 47.22% <ø> (+0.03%) ⬆️
pyamber 90.83% <ø> (ø)
python 90.74% <ø> (ø) Carriedforward from 9a989b4
workflow-compiling-service 58.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yicong-Huang
Yicong-Huang requested a review from xuang7 July 29, 2026 02:58
@Yicong-Huang
Yicong-Huang merged commit fd5f487 into release/v1.2 Jul 29, 2026
54 of 58 checks passed
@Yicong-Huang
Yicong-Huang deleted the ci/6989-sbt-setup-sbt-v1.5.2-v1.2 branch July 29, 2026 03:39
renovate-bot pushed a commit to renovate-bot/apache-_-texera that referenced this pull request Nov 6, 2026
### What changes were proposed in this PR?

Nothing can merge into main right now. Every job that sets up sbt
(`amber`, `amber-integration`, `platform` ×6, `platform-integration` ×6,
`Bench`, the image builds and the dependency graph) has died at `Setup
sbt launcher` since 2026-11-05 15:36 UTC, on main itself and on every
PR, so `Required Checks` is red and the merge queue takes nothing.
Nothing in this repository changed: main at `312a0cefc` (apache#9325, run at
07:16 UTC) was green, main at `8b0fb168e` (apache#8848, run at 20:54 UTC) is
red, and that commit touches three frontend files.

Before: Scala job -> sbt/setup-sbt v1.5.12 -> "Verify the sbt
distribution signature" reads carabiner-dev/policies at HEAD -> ampel
v1.3.6 cannot parse it -> exit 1 before sbt is installed
After: Scala job -> sbt/setup-sbt v1.5.14 -> the same step reads the
policy pinned at carabiner-dev/policies@971d670e9 -> sbt installs -> the
job runs

Root cause. v1.5.12 hands `carabiner-dev/actions/ampel/verify@32587e8`
(ampel v1.3.6) the policy argument
`git+https://github.com/carabiner-dev/policies#signature/signature.json`,
with no ref, so the policy is whatever that repository's main holds at
run time. On 2026-11-05 `signature/signature.json` gained a `meta.name`
field that ampel v1.3.6 rejects, and ampel exits while loading the
policy with `compiling policy: unable to parse a policy, group or
policySet from data`. The step's `fail: false` covers a failed
verification verdict, not the loader exiting, so the composite action
fails and the job stops. sbt/setup-sbt#155, released as v1.5.14 the same
day, pins the policy to
`carabiner-dev/policies@971d670e93f2fb4da304b0e5f071066dc4686a5a`, a
commit without the field.

Change. All 9 call sites (`build.yml` ×4, `build-and-push-images.yml`
×3, `benchmarks.yml`, `dependency-graph.yml`) move from
`ecad189dd245444b9ae0a0cd5922fd938b88906f` (v1.5.12) to
`67d461eba2c4753196c230e02da850757ba4775e` (v1.5.14), as apache#9100 moved
them to v1.5.12. Between the two versions `action.yml` differs in two
lines: the policy pin above and the default `sbt-runner-version` (2.0.10
-> 2.0.12), which this repository does not use because
`project/build.properties` sets `sbt.version`. The nested actions,
`actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9` and
`carabiner-dev/actions/ampel/verify@32587e82f960d49b36101e8c45d1956e511965d3`,
are the same in both, and no call site passes inputs.

Scope. v1.5.13 is already on the ASF allow list but carries the same
unpinned policy line, so it fails the same way; v1.5.14 is the first
version that does not. This PR changes nothing about what the signature
step does when it runs; it only stops the step from reading a moving
target.

**Blocked on apache/infrastructure-actions#1498.**
`sbt/setup-sbt@67d461eba` is not on the ASF actions allow list yet;
apache#1498 (opened 2026-11-05 13:39 UTC) adds it. Until it merges, every sbt
job on this PR fails at `Set up job` with the action not allowed, which
is how v1.5.7 failed in apache#9100, so the red checks here are expected and
this PR must not be merged before apache#1498 lands. Once it does, a re-run of
the failed jobs is the proof; nothing in this branch needs to change.

### Any related issues, documentation, discussions?

Closes apache#9345.

Upstream fix: sbt/setup-sbt#155 (v1.5.14). Allow-list entry:
apache/infrastructure-actions#1498. Precedent: apache#9100 moved the same 9
call sites to v1.5.12 after the ASF allow list dropped the actions
v1.5.7 reached, with backports apache#9132 (v1.3) and apache#9133 (v1.2); apache#7710 and
apache#6990 are the earlier bumps of the same kind.

### How was this PR tested?

Every changed file parses:

```
python -I -c "import sys, yaml; [yaml.safe_load(open(f, encoding='utf-8')) for f in sys.argv[1:]]" .github/workflows/build.yml .github/workflows/build-and-push-images.yml .github/workflows/benchmarks.yml .github/workflows/dependency-graph.yml
```

`git ls-remote --tags https://github.com/sbt/setup-sbt.git` resolves
`refs/tags/v1.5.14^{}` to `67d461eba2c4753196c230e02da850757ba4775e`.
Diffing `action.yml` at `ecad189` against `67d461eba` shows only the two
lines described above, with identical `uses:` lines. Walking the `uses:`
chain under v1.5.14 reaches `ampel/verify@32587e8`, which is in
`apache/infrastructure-actions` `approved_patterns.yml`;
`sbt/setup-sbt@67d461eba` itself is not yet, which
apache/infrastructure-actions#1498 adds.

The rest is CI. The labeler applies `ci` for `.github/**`, which runs
every stack that sets up sbt. Those jobs cannot pass until
apache/infrastructure-actions#1498 lands (see above); the re-run after
that is the test, and the checks on this PR are the first run of v1.5.14
in this repository.

### Was this PR authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Code (claude-fable-5-1). Co-authored with
Claude; the author reviewed the change before submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants