Repository navigation
fix(backend): prevent workflow cloning when user revokes own access - #4153
Merged
Xiao-zhen-Liu merged 5 commits intoJan 14, 2026
Merged
Xiao-zhen-Liu merged 5 commits into
Xiao-zhen-Liu merged 5 commits into
Conversation
Contributor
Author
|
@Xiao-zhen-Liu Sorry, this is the correct PR. |
Xiao-zhen-Liu
self-requested a review
January 12, 2026 22:43
Xiao-zhen-Liu
approved these changes
Jan 12, 2026
Xiao-zhen-Liu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
Contributor
|
@seongjinyoon Please fix the test cases. |
Contributor
Author
|
@Xiao-zhen-Liu Thank you for the review. I have made the according changes. Please merge the PR. |
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
…pache#4153) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> This PR fixes a bug where workflow were cloned when users revoked their own access to a shared workflow while having it open in the workspace. **Bug:** When a user revoked their own access while editing a shared workflow, the frontend's auto-persist would continue to save changes. The backend's `persistWorkflow` method would receive these save requests from a user who no longer has access, and create a new workflow. **Changes Made:** **Backend (`WorkflowResource.scala`):** - Modified `persistWorkflow()` method to distinguish between: - Creating a new workflow (workflow ID is null) - Persisting an existing workflow without access (workflow ID is not null) **Frontend (`ShareAccessComponent`):** - Added `verifyRevokeAccess()` method that shows a confirmation modal before revoking access. - Made `revokeAccess()` private and updated it to return a flag when user revokes their own access. **Frontend (`MenuComponent`):** - Added redirect logic to navigate users to the workflows list page when they revoke their own access while in the workspace. **Frontend (`share-access.component.html`):** - Updated delete button to call `verifyRevokeAccess()` instead of `revokeAccess()` to trigger confirmation popup. **Before:** https://github.com/user-attachments/assets/35ef739c-40b7-461f-b0c6-01bc565d98dd **After:** https://github.com/user-attachments/assets/3945dc67-0a4f-477f-8f10-ca773bb9604e ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> None. ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Manually tested. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No. --------- Co-authored-by: Xiaozhen Liu <[email protected]>
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
…pache#4153) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> This PR fixes a bug where workflow were cloned when users revoked their own access to a shared workflow while having it open in the workspace. **Bug:** When a user revoked their own access while editing a shared workflow, the frontend's auto-persist would continue to save changes. The backend's `persistWorkflow` method would receive these save requests from a user who no longer has access, and create a new workflow. **Changes Made:** **Backend (`WorkflowResource.scala`):** - Modified `persistWorkflow()` method to distinguish between: - Creating a new workflow (workflow ID is null) - Persisting an existing workflow without access (workflow ID is not null) **Frontend (`ShareAccessComponent`):** - Added `verifyRevokeAccess()` method that shows a confirmation modal before revoking access. - Made `revokeAccess()` private and updated it to return a flag when user revokes their own access. **Frontend (`MenuComponent`):** - Added redirect logic to navigate users to the workflows list page when they revoke their own access while in the workspace. **Frontend (`share-access.component.html`):** - Updated delete button to call `verifyRevokeAccess()` instead of `revokeAccess()` to trigger confirmation popup. **Before:** https://github.com/user-attachments/assets/35ef739c-40b7-461f-b0c6-01bc565d98dd **After:** https://github.com/user-attachments/assets/3945dc67-0a4f-477f-8f10-ca773bb9604e ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> None. ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Manually tested. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No. --------- Co-authored-by: Xiaozhen Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes a bug where workflow were cloned when users revoked their own access to a shared workflow while having it open in the workspace.
Bug:
When a user revoked their own access while editing a shared workflow, the frontend's auto-persist would continue to save changes. The backend's
persistWorkflowmethod would receive these save requests from a user who no longer has access, and create a new workflow.Changes Made:
Backend (
WorkflowResource.scala):persistWorkflow()method to distinguish between:Frontend (
ShareAccessComponent):verifyRevokeAccess()method that shows a confirmation modal before revoking access.revokeAccess()private and updated it to return a flag when user revokes their own access.Frontend (
MenuComponent):Frontend (
share-access.component.html):verifyRevokeAccess()instead ofrevokeAccess()to trigger confirmation popup.Before:
Before.mov
After:
After.mov
Any related issues, documentation, discussions?
#4153
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
No.