Repository navigation
[Issue #246] GUI: Add a frontend menu with default operators - #291
Merged
Merged
Conversation
kishore-narendran
changed the title
chenlica
changed the title
chenlica
changed the title
kishore-narendran
changed the base branch from
jimmy-ui-thirdparty
to
master
November 23, 2016 22:49
| <!-- Menu --> | ||
| <ul> | ||
| <li class="-matcher">Create Matcher</li> | ||
| <li class="-matcher">Create Matcher</li> |
Contributor
There was a problem hiding this comment.
Class names, are usually all lowercase. Or are delimited by -, _.
chenlica
changed the title
chenlica
changed the title
| @@ -0,0 +1,34 @@ | |||
| var main = function(){ | |||
|
|
|||
| $('.icon-menu').click(function(){ | |||
Contributor
There was a problem hiding this comment.
Don't use anonymous functions, declare the function above as var iconMenuClick = function() {}
| }, 200); | ||
| }); | ||
|
|
||
| $('.icon-close').click(function(){ |
Contributor
There was a problem hiding this comment.
Assign the function to a variable and then pass it on.
chenlica
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic structure of index.html
setup basic formatting with style.css / basic javascript with app.js