Skip to content

Add Hub - #2725

Merged
GspikeHalo merged 60 commits into
masterfrom
texera-hub
Sep 24, 2024
Merged

Add Hub#2725
GspikeHalo merged 60 commits into
masterfrom
texera-hub

Conversation

@YS0meone

@YS0meone YS0meone commented Jul 11, 2024 •

Copy link
Copy Markdown
Contributor

Propose:
This pull request introduces a new Hub feature to the Texera platform.

Changes:

  • Add new components for the Hub interface.
  • Updates to the dashboard menu to incorporate Hub navigation.
  • Numerous updates and fixes to refine the functionality and ensure compatibility.
  • This enhancement aims to provide a centralized hub for managing various elements within the Texera system, improving user experience and navigation efficiency.

Demo:
Interface before login:
previous home interface:
previous_home_interface

now home interface:
home_page_no_login

now hub-workflow:
workflow_page_search_page

Interface after login:
previous workflow-interface:
previous_interface

now workflow-interface:
after_login

@aglinxinyuan
aglinxinyuan self-requested a review July 14, 2024 06:39
@aglinxinyuan
aglinxinyuan marked this pull request as ready for review July 15, 2024 22:14
@aglinxinyuan
aglinxinyuan marked this pull request as draft July 15, 2024 22:14

@aglinxinyuan aglinxinyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GspikeHalo
GspikeHalo merged commit 7a21048 into master Sep 24, 2024
@GspikeHalo
GspikeHalo deleted the texera-hub branch September 24, 2024 06:35
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
**Propose:**
This pull request introduces a new Hub feature to the Texera platform. 

**Changes:**
- Add new components for the Hub interface.
- Updates to the dashboard menu to incorporate Hub navigation.
- Numerous updates and fixes to refine the functionality and ensure
compatibility.
- This enhancement aims to provide a centralized hub for managing
various elements within the Texera system, improving user experience and
navigation efficiency.

**Demo:**
Interface before login:
previous home interface:

![previous_home_interface](https://github.com/user-attachments/assets/b4031170-ca38-4dd0-9201-477e807b32d8)

now home interface:

![home_page_no_login](https://github.com/user-attachments/assets/9d1fe994-eb4f-4310-88c6-c2e1efa8c6b7)

now hub-workflow:

![workflow_page_search_page](https://github.com/user-attachments/assets/10132eba-dc2a-4e50-98aa-c7a79cc695cb)

Interface after login:
previous workflow-interface:

![previous_interface](https://github.com/user-attachments/assets/9c219871-896a-4bbb-ae20-9908b99b272a)

now workflow-interface:

![after_login](https://github.com/user-attachments/assets/2da720f0-b77f-459a-be60-766c5cda4dc9)

---------

Co-authored-by: Xinyuan Lin <[email protected]>
Co-authored-by: linxinyuan <[email protected]>
Co-authored-by: sixsage <[email protected]>
Co-authored-by: gspikehalo <[email protected]>
Co-authored-by: mengw15 <[email protected]>
Co-authored-by: Minchong(Brian) Wu <[email protected]>
Co-authored-by: Yicong Huang <[email protected]>
Co-authored-by: Yicong Huang <[email protected]>
Co-authored-by: GspikeHalo <[email protected]>
SarahAsad23 pushed a commit to madisonmlin/texera that referenced this pull request May 20, 2026
**Propose:**
This pull request introduces a new Hub feature to the Texera platform. 

**Changes:**
- Add new components for the Hub interface.
- Updates to the dashboard menu to incorporate Hub navigation.
- Numerous updates and fixes to refine the functionality and ensure
compatibility.
- This enhancement aims to provide a centralized hub for managing
various elements within the Texera system, improving user experience and
navigation efficiency.

**Demo:**
Interface before login:
previous home interface:

![previous_home_interface](https://github.com/user-attachments/assets/b4031170-ca38-4dd0-9201-477e807b32d8)

now home interface:

![home_page_no_login](https://github.com/user-attachments/assets/9d1fe994-eb4f-4310-88c6-c2e1efa8c6b7)

now hub-workflow:

![workflow_page_search_page](https://github.com/user-attachments/assets/10132eba-dc2a-4e50-98aa-c7a79cc695cb)

Interface after login:
previous workflow-interface:

![previous_interface](https://github.com/user-attachments/assets/9c219871-896a-4bbb-ae20-9908b99b272a)

now workflow-interface:

![after_login](https://github.com/user-attachments/assets/2da720f0-b77f-459a-be60-766c5cda4dc9)

---------

Co-authored-by: Xinyuan Lin <[email protected]>
Co-authored-by: linxinyuan <[email protected]>
Co-authored-by: sixsage <[email protected]>
Co-authored-by: gspikehalo <[email protected]>
Co-authored-by: mengw15 <[email protected]>
Co-authored-by: Minchong(Brian) Wu <[email protected]>
Co-authored-by: Yicong Huang <[email protected]>
Co-authored-by: Yicong Huang <[email protected]>
Co-authored-by: GspikeHalo <[email protected]>
yangzhang75 pushed a commit to yangzhang75/texera that referenced this pull request Jun 22, 2026
**Propose:**
This pull request introduces a new Hub feature to the Texera platform. 

**Changes:**
- Add new components for the Hub interface.
- Updates to the dashboard menu to incorporate Hub navigation.
- Numerous updates and fixes to refine the functionality and ensure
compatibility.
- This enhancement aims to provide a centralized hub for managing
various elements within the Texera system, improving user experience and
navigation efficiency.

**Demo:**
Interface before login:
previous home interface:

![previous_home_interface](https://github.com/user-attachments/assets/b4031170-ca38-4dd0-9201-477e807b32d8)

now home interface:

![home_page_no_login](https://github.com/user-attachments/assets/9d1fe994-eb4f-4310-88c6-c2e1efa8c6b7)

now hub-workflow:

![workflow_page_search_page](https://github.com/user-attachments/assets/10132eba-dc2a-4e50-98aa-c7a79cc695cb)

Interface after login:
previous workflow-interface:

![previous_interface](https://github.com/user-attachments/assets/9c219871-896a-4bbb-ae20-9908b99b272a)

now workflow-interface:

![after_login](https://github.com/user-attachments/assets/2da720f0-b77f-459a-be60-766c5cda4dc9)

---------

Co-authored-by: Xinyuan Lin <[email protected]>
Co-authored-by: linxinyuan <[email protected]>
Co-authored-by: sixsage <[email protected]>
Co-authored-by: gspikehalo <[email protected]>
Co-authored-by: mengw15 <[email protected]>
Co-authored-by: Minchong(Brian) Wu <[email protected]>
Co-authored-by: Yicong Huang <[email protected]>
Co-authored-by: Yicong Huang <[email protected]>
Co-authored-by: GspikeHalo <[email protected]>
aglinxinyuan added a commit to aglinxinyuan/texera that referenced this pull request Oct 5, 2026
Under emulated encapsulation Angular compiles the component's `body`
rule to body[_ngcontent-...]. The document <body> comes from index.html
and never carries that attribute, so the rule has matched nothing since
apache#2725 added it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
renovate-bot pushed a commit to renovate-bot/apache-_-texera that referenced this pull request Oct 5, 2026
### What changes were proposed in this PR?

Removes three leftovers from `HubWorkflowDetailComponent`. **−24
lines.** There is no behaviour change.

- **Template:** the empty `<ng-template #codeEditor></ng-template>`.
Nothing reads it: the component has no `@ViewChild`, and the only other
`#codeEditor` in the app is the live one in `workspace.component.html`.
- **Styles:** the `.workflow-steps`, `.workflow-step`, `.workflow-step
h3` and `.workflow-step p` rules, which no markup uses.
- **Styles:** the `body` rule. Under the default emulated encapsulation
Angular compiles it to `body[_ngcontent-…]`, and the document `<body>`
(static in `index.html`) never carries that attribute, so it matches
nothing.

### History

| | |
| --- | --- |
| **Introduced by** | apache#2725 (2024-09-24), "Add Hub": the step styles and
the `body` rule. apache#2873 (2024-09-27), "Add workflow preview to hub
details page": the `#codeEditor` anchor |
| **Usage removed by** | apache#3006 (2024-11-05), "Remove home page and step
from the detail page": the step markup. apache#3007 (2024-11-05), "Fix sharing
issue of hub preview": the `@ViewChild("codeEditor")` that read the
anchor. The `body` rule never matched anything |

The step styles and the anchor have been dead for nearly two years. The
`body` rule never took effect.

### Any related issues, documentation, discussions?

Closes apache#8747

### How was this PR tested?

No new tests.

From `frontend/`:

- `npx ng test --watch=false
--include='**/hub-workflow-detail.component.spec.ts'
--include='**/card-item.component.spec.ts'
--include='**/list-item.component.spec.ts'
--include='**/workspace.component.spec.ts'`: 4 files, 221 tests, all
pass. The card-item and list-item specs open this component in a modal,
and the workspace spec owns the live `#codeEditor`.
- `yarn format:ci`: clean.
- `npx ng build`: success.
- After also removing the `body` rule: the hub-workflow-detail,
card-item and list-item specs pass (3 files, 186 tests), and `prettier
--check` on the stylesheet is clean.

To re-check:

```
git grep -n "workflow-step" -- frontend   # no hits
grep -n "^body" frontend/src/app/hub/component/workflow/detail/hub-workflow-detail.component.scss   # no hits
```

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
renovate-bot pushed a commit to renovate-bot/apache-_-texera that referenced this pull request Oct 8, 2026
### What changes were proposed in this PR?

Removes two rules from the hub About page's stylesheet that style
nothing: `#logo` and `.login-container`. **−11 lines.** There is no
behaviour change. The component uses emulated encapsulation, so these
rules can only match its own template, and no element there uses either
selector, statically or dynamically. No code adds them at runtime, and
no other stylesheet relies on them.

### History

| | |
| --- | --- |
| **Introduced by** | apache#2324 (2024-01-24), "Remove bootstrap from
navigation bars": `#logo`. apache#3119 (2024-12-01), "Update Texera Hub About
Page": `.login-container` |
| **Usage removed by** | apache#2725 (2024-09-24), "Add Hub", removed the `<li
id="logo">` element; the stylesheet then moved with the component
unchanged. apache#7339 (2026-08-10), "consolidate login onto a dedicated
/login page", removed the embedded `<texera-local-login
class="login-container">` |

`#logo` has been dead for two years and `.login-container` for two
months.

### Any related issues, documentation, discussions?

Closes apache#8878

### How was this PR tested?

No new tests; no spec referenced either selector.

From `frontend/`:

- `npx ng test --watch=false --include='**/about.component.spec.ts'
--include='**/user-icon.component.spec.ts'`: 2 files, 5 tests, all pass.
The user-icon spec routes to the About page.
- `yarn format:ci`: clean.
- `npx ng build`: success.

To re-check:

```
git grep -n "login-container" -- frontend   # no hits
```

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
renovate-bot pushed a commit to renovate-bot/apache-_-texera that referenced this pull request Oct 26, 2026
)

### What changes were proposed in this PR?

Deletes `frontend/src/app/hub/component/type/hub-workflow.interface.ts`,
a type file nothing imports. It is the only file in
`hub/component/type/`, so that directory goes too. **−27 lines.** There
is no behaviour change.

The file exports `HubWorkflow`. No code, spec, barrel file or path alias
references the file or the interface; the similarly named
`HubWorkflowDetailComponent` and `HUB_WORKFLOW*` route constants are
unrelated. No open PR adds an import.

### History

| | |
| --- | --- |
| **Introduced by** | apache#2725 (2024-09-24), "Add Hub", for the hub
workflow list |
| **Usage removed by** | apache#2928 (2024-10-29), "Add landing page", which
deleted the components that listed workflows with it. apache#3252 (2025-02-09)
then deleted the last, already unused, importer |

It has been unused for the two years since apache#2928.

### Any related issues, documentation, discussions?

Closes apache#9108

### How was this PR tested?

No new tests; nothing referenced the file.

From `frontend/`:

- `npx tsc --noEmit -p src/tsconfig.app.json` and `-p
src/tsconfig.spec.json`: clean.
- `yarn format:ci`: clean.
- `npx ng build`: success.

To re-check:

```
git grep -n -w HubWorkflow   # no hits
git grep -n "hub-workflow.interface"   # no hits
```

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants