Repository navigation
Migrate all control handling logics to AsyncRPC and cleanup Amber - #1000
Merged
Merged
Conversation
added 9 commits
January 26, 2021 13:36
This was
linked to
issues
Jan 31, 2021
avinash0161
approved these changes
Jan 31, 2021
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
…ache#1000) On high level, this PR: 1. made `workerlayer`, `opexecconfig`, `linkstrategy`, `workflow` object more usable and they contain mutable state information now. 2. rewrote all the control handling logic to asyncRPC 3. reworked `WorkflowPartialCompleted` mechanism. now workers will send `LinkCompleted` message whenever the receiver of a link receives all the data from the senders of that link. 4. replaced all `AmberTag` to `VirtualIdentity`, now `VirtualIdentity` is the only identifier we use in the code. 5. codebase cleanup. After the merge of this PR, the major refactoring effort of Amber is DONE in my opinion. (I would like to call it the Amber2.0 now)
1 of 6 tasks
renovate-bot
pushed a commit
to renovate-bot/apache-_-texera
that referenced
this pull request
Nov 9, 2026
…#8396) ### What changes were proposed in this PR? Deletes `MockKillWorkerResource.scala`, a file whose every non-blank line after the ASF header is a comment — the commented-out remains of a JAX-RS `/kill/worker` endpoint — together with the commented-out Jersey registration line in `TexeraWebApplication` that pointed at it. Pure deletion, no behaviour change: **−40 lines**, none of them compiled. ### History | | | | --- | --- | | **Introduced by** | the initial amber import, commit `41a8a92017` (2020-08-20) — predates the PR workflow — which also registered it live with Jersey | | **Disabled by** | apache#1000 (`4a64935c35`, 2021-01-30) — "Migrate all control handling logics to AsyncRPC and cleanup Amber" commented out the registration line and the whole file body in the same diff. Nothing has compiled from the file since | Registered live for about five months, 2020-08-20 → 2021-01-30, then commented out for the five and a half years since. The commented registration line goes with the file. ### Any related issues, documentation, discussions? Closes apache#8393 ### How was this PR tested? Existing tests only — no spec referenced it. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success. - `sbt scalafmtCheckAll "scalafixAll --check"` — clean. Verification, re-runnable by a reviewer: ``` git grep -n MockKillWorkerResource # nothing left on this branch; on main, two hits: the file and the commented registration line git grep -n "jersey.register" -- amber/src/main # the live registrations, untouched ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5, Claude Fable 5.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On high level, this PR:
workerlayer,opexecconfig,linkstrategy,workflowobject more usable and they contain mutable state information now.WorkflowPartialCompletedmechanism. now workers will sendLinkCompletedmessage whenever the receiver of a link receives all the data from the senders of that link.AmberTagtoVirtualIdentity, nowVirtualIdentityis the only identifier we use in the code.After the merge of this PR, the major refactoring effort of Amber is DONE in my opinion. (I would like to call it the Amber2.0 now)