Skip to content

Remove the unused BufferedItemWriter.removeOne #8743

Closed

Description

@aglinxinyuan

Task Summary

The buffered-writer API has a removeOne (Scala) / remove_one (pyamber) method that no production code calls in either language.

Introduced by:

Usage removed by #3295 (2025-03-09, "Use Output Ports of an Operator to Write Storage"). It commented out the last live call, writer.removeOne(tupleValue) in the progressive sink's set-snapshot retraction branch, and #3312 later deleted the commented line. The Python remove_one was never used.

It has been dead for eighteen months. What remains is the trait method, the Iceberg implementation in both languages, a no-op override in an amber test stub, and three test cases.

This is a pure deletion with no behaviour change.

Task Type

  • Refactor / Cleanup

Activity

  1. added a commit that references this issue on Oct 5, 2026
    0fc6e78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions