Repository navigation
The Private / Public buttons are gone from the share dialog #8599
Description
What happened?
The share dialog for a workflow no longer offers the Private / Public choice — the two buttons at the top of the dialog are simply not there. Everything else in it (the owner, the access list, the invite form) renders as usual, so nothing indicates that anything failed. Video attached.
A guess at the cause, not verified: those buttons are rendered only once the dialog has read the workflow's current publish state (*ngIf="isPublic !== null", share-access.component.html), and the subscription that fills it has no error handler, so a failed GET /workflow/type/{wid} would hide them with no sign of the failure. WorkflowResource.getWorkflowType reads workflowDao.fetchOneByWid(wid) and dereferences it without a null check, which throws for an id that matches no row. Worth checking that request in the network tab first.
How to reproduce?
Switch between the Canvas and the Form View, then open the share dialog. See the attached video.
Screencast.from.09-18-2026.12_56_59.PM.webm
Version/Branch
1.4.0-incubating-SNAPSHOT (main)
Commit Hash (Optional)
What browsers are you seeing the problem on?
Chrome
Relevant log output
Check the network tab for GET /api/workflow/type/{wid} while the dialog opens.
Activity
github-actions commentedon Sep 18, 2026
👋 Thanks for opening this issue, @mengw15!
It looks like the issue description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.
yangzhang75 commentedon Sep 18, 2026
/take
fix(workflow): stop pages destroying themselves on beforeunload
fix(workflow): stop the workspace destroying itself on beforeunload
fix(workflow): gate the share dialog on a loaded workflow, and drop a…
fix(workflow): stop the workspace destroying itself on beforeunload (a…
fix(workflow): announce the metadata to a view handed an open workflow
fix(frontend): stop inventing a state transition, and keep the mini-m…
fix(workflow): announce the metadata to a view handed an open workflow
fix(frontend): stop inventing a state transition, and keep the mini-m…