Skip to content

Commit be65bf8

Browse files
aglinxinyuanaglinxinyuan
authored
refactor(frontend): remove the unused loadFile output (#8892)
### What changes were proposed in this PR? Removes the unused `@Output() loadFile` from `UserDatasetFileRendererComponent`, along with `EventEmitter` and `Output` from its `@angular/core` import, since nothing else in the file uses them. **+1/−4 lines.** There is no behaviour change: the component never emits `loadFile`, and its two hosts (`dataset-detail` and `model-detail`) bind only inputs on `<texera-user-dataset-file-renderer>`. ### History | | | | --- | --- | | **Introduced by** | #2413 (2024-02-26), "Introduce Dataset GUI", with the file renderer itself | | **Usage removed by** | **never used**. No `(loadFile)` binding or `.emit` has ever existed | It has been unused for the nineteen months since it was added. ### Any related issues, documentation, discussions? Closes #8891 ### How was this PR tested? No new tests; no spec referenced the output. From `frontend/`: - `npx ng test --watch=false --include='**/user-dataset-file-renderer.component.spec.ts' --include='**/dataset-detail.component.spec.ts' --include='**/model-detail.component.spec.ts'`: 3 files, 286 tests, all pass. The last two specs cover the renderer's two hosts. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -w "loadFile" -- frontend/src # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 parent a42c573 commit be65bf8

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

‎frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* under the License.
1818
*/
1919

20-
import { Component, EventEmitter, Input, OnChanges, OnDestroy, OnInit, Output, SimpleChanges } from "@angular/core";
20+
import { Component, Input, OnChanges, OnDestroy, OnInit, SimpleChanges } from "@angular/core";
2121
import { ResourceRegistryService } from "../../../../../service/user/resource-registry/resource-registry.service";
2222
import { EntityType } from "../../../../../../hub/service/hub.service";
2323
import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy";
@@ -166,9 +166,6 @@ export class UserDatasetFileRendererComponent implements OnInit, OnChanges, OnDe
166166
@Input()
167167
isLogin: boolean = false;
168168

169-
@Output()
170-
loadFile = new EventEmitter<{ file: string; prefix: string }>();
171-
172169
constructor(
173170
private resourceRegistry: ResourceRegistryService,
174171
private sanitizer: DomSanitizer,

0 commit comments

Comments
 (0)