You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bb46d20
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(amber): remove the materialization reader thread's finished flag
After the fix, nothing outside tests reads InputPortMaterializationReaderThread
.finished, and it is exactly the signal that must not stand for port
completion. Remove it. The tests that read it now check what it stood
for: the END_CHANNEL the reader enqueued, or the thread's own state.
Copy file name to clipboardExpand all lines: amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/managers/InputPortMaterializationReaderThread.scala
Copy file name to clipboardExpand all lines: amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/managers/InputPortMaterializationReaderThreadSpec.scala
+18-27Lines changed: 18 additions & 27 deletions
Original file line number
Diff line number
Diff line change
@@ -157,20 +157,15 @@ class InputPortMaterializationReaderThreadSpec extends AnyFlatSpec {
157
157
hashAttributeNames =Seq("id")
158
158
)
159
159
160
-
/**
161
-
* Runs the reader inline and returns everything it enqueued, in order, together with the reader
162
-
* itself so its completion flag can be read.
163
-
*/
160
+
/** Runs the reader inline and returns everything it enqueued, in order. */
Copy file name to clipboardExpand all lines: amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/promisehandlers/EndChannelHandlerSpec.scala
0 commit comments